GithubHelp home page GithubHelp logo

Comments (11)

jena-chakour avatar jena-chakour commented on August 21, 2024 2

Hi @polurezov8 thanks for surfacing this. Our team is reviewing, and we will update here as soon as possible with the findings and resolution.

from swift-sdk.

polurezov8 avatar polurezov8 commented on August 21, 2024 1

Issue Summary

From the provided Swift code, it appears that the crash is related to the createRequestHandler method, which is an integral part of your dependency injection system. The root cause of the crash likely pertains to how the DependencyContainerProtocol is creating and managing objects.

Investigation Steps

To address and potentially resolve this issue, consider the following steps:

  1. Review the createRequestHandler Method: Take a closer look at the createRequestHandler method in the DependencyContainerProtocol to ensure that it correctly initializes objects and manages memory. Verify that object creation is error-free and adheres to best practices.

  2. Check for Unwrapped Optionals: Check for any optional values within the createRequestHandler method that may not be properly unwrapped, potentially causing unexpected crashes. Ensure that optionals are handled safely.

  3. Examine Object Lifecycle: Investigate the lifecycle of objects created within this method. Ensure that objects are retained and released appropriately to prevent memory leaks and crashes.

  4. Review Dependencies: Examine any dependencies that the createRequestHandler method relies on. Confirm that these dependencies are correctly configured and initialized. Ensure that dependencies are available when needed.

  5. Error Handling and Logging: Consider adding robust error handling and logging mechanisms to the createRequestHandler method. Detailed error messages and logs can provide valuable insights into the root cause of the crashes.

Conclusion

It is crucial to conduct a thorough investigation of the code within the createRequestHandler method and its associated dependencies. Identifying the precise cause of the crashes is essential for effective troubleshooting. Additionally, a review of recent changes in the Swift code related to memory management and object creation may help pinpoint the issue.

Your attention to these steps will greatly assist in resolving the problem and improving the stability of the application.

Please let me know if you require any further assistance or have additional information to provide.

from swift-sdk.

m-yeroshenko avatar m-yeroshenko commented on August 21, 2024 1

I'd like to draw attention to this issue because it also affects the application I'm working on.
Such crash has a substantial negative impact on user satisfaction with our app.
My team is eager to find a solution to address this problem as we want to provide the best possible user experience.

Thank you in advance for your efforts in addressing this matter!

from swift-sdk.

polurezov8 avatar polurezov8 commented on August 21, 2024 1

@jena-chakour Hi! Any developments on this issue?
We're experiencing a -3% impact on our crash-free rating due to this bug.

from swift-sdk.

m-yeroshenko avatar m-yeroshenko commented on August 21, 2024 1

@jena-chakour Hi!
Are there any updates about this issue?
Would be great to find a solution ASAP

from swift-sdk.

jyu115 avatar jyu115 commented on August 21, 2024

hi @polurezov8 @m-yeroshenko, we are looking into this issue. If possible, can I get more details about the devices on which the crash happens?

from swift-sdk.

polurezov8 avatar polurezov8 commented on August 21, 2024

Hi @jyu115!
Devices:
98% - iPhone
2% - iPad

iOS Version:
53% - iOS 17
43% - iOS 16
2% - iOS 15
2% - other

This issue has 2,827 crash events affecting 2,392 users last week and it's critical for us.

from swift-sdk.

jena-chakour avatar jena-chakour commented on August 21, 2024

Hi all @m-yeroshenko @ @polurezov8! Appreciate your patience while we work on this. We've not been able to replicate the crash so far, so I've reached out to Olena for more recent test cases

from swift-sdk.

hardikmashru avatar hardikmashru commented on August 21, 2024

@m-yeroshenko Are you getting these crashes in the debug environment too?

from swift-sdk.

m-yeroshenko avatar m-yeroshenko commented on August 21, 2024

Hi all!
@hardikmashru Compared to the production environment, we have a significantly lower number of sessions. However, as far as I know, we haven't observed this crash in our debug builds. Additionally, I attempted to reproduce the issue in the debug build on iOS 15.8, 16.0, and 17.2 following your question, but I couldn't replicate it.

from swift-sdk.

polurezov8 avatar polurezov8 commented on August 21, 2024

@hardikmashru @jena-chakour @jyu115
Any updates here?

from swift-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.