Add ES6 -> ES5 build step about favicons

[haydenbleasel]

Ughhh I hoped nobody would pick up on this and just upgrade to Node 4.x haha. But yeah you're right. Do you reckon you could help out with a PR on this? I'm not sure the best way of doing it. Otherwise I can probably figure it out next week sometime.

[davewasmer]

Sorry 😉

Happy to PR if I can find the time. I'd suggest something like https://github.com/jmeas/es6-node-boilerplate - I've used similar boilerplates in the past. Basic idea is to setup gulp (or something similar) to compile (as well as test/lint/code coverage if you'd like) everything from src/ into dist/. Then you .gitignore the distributed files, and .npmignore the source files.

Can't promise when I'll get to it exactly, but hopefully soon ish

[haydenbleasel]

Hey @davewasmer, fixed in [email protected]. Just require('favicons/es5'). The helpers file is still in ES6 though. Not sure how to go about that.

[davewasmer]

I haven't been able to test it yet, but my guess is that won't work. Unless the consuming app has done something like require('babel/register'), when your es5.js file attempts to require('./helpers'), it's going to try to parse that file, and will hit errors on the es6 syntax.

[haydenbleasel]

@davewasmer I've updated Favicons to use an ES5 helpers file until ES6 is completely supported.