GithubHelp home page GithubHelp logo

Comments (1)

AhmedNSidd avatar AhmedNSidd commented on June 2, 2024 1

Update

I think I've found out what the issue is. As said in the OP, the question lies in the resiliency of the content/classes.py. Specially in lines 1307 - 1317:

# if all seasons of the show could also be downloaded as single-season packs, compare the quality of the best ranking multi season pack with the lowest quality of the single season packs.
if not download_multi_season_release:
    season_quality = min(season_releases)
    quality = regex.search(
        '(2160|1080|720|480)(?=p|i)', multi_season_releases[0].title, regex.I)
    if quality:
        quality = int(quality.group())
    else:
        quality = 0
    if quality >= season_quality:
        download_multi_season_release = True

The heuristic above is used to determine whether a multi-season pack should be used instead of single season packs. However, this heuristic as proven by the existence of this issue proves that it's not exactly correct / desirable.

One fool-proof way of ensuring that we pick the highest quality is to calculate the average bitrates of the multi-season release vs the average bitrates of the single season releases and compare those two metrics.

Thing is, I'm not sure if we have enough information to calculate those metrics, but I'll figure that out the more I play with this scenario.

from plex_debrid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.