GithubHelp home page GithubHelp logo

Some pages can't be parsed about iframely HOT 6 CLOSED

itteco avatar itteco commented on June 24, 2024
Some pages can't be parsed

from iframely.

Comments (6)

nleush avatar nleush commented on June 24, 2024

The known issue is explicit parser error: http://iframely.com/debug?uri=%20http%3A%2F%2Fdabblet.com%2F%20

Unexpected end Line: 186 Column: 7 Char:

SAX really have some issues with processing invalid tags. I was trying to fix that but haven't enough time yet to handle it.

We have two common requirements for parser to use in current algorithm:

  1. Working with stream - to process meta before all response retrieved.
  2. Working with tags - to simplify generation of meta.

So looks like its possible to use node-htmlparser2.

You can try to port iframely-meta to another parser. We will test in on all our plugins to see how is it stable.

P.S. all plugins testing is available with forever start ./modules/test-dashboard/tester.js but tests config section should be enabled, results on '/tests'.

from iframely.

nleush avatar nleush commented on June 24, 2024

About issue with skipping meta tags.

Its really strange, reproduced only locally and not all the time. As I see parser stops working on META viewport tag and continues on META pinterest:following tag. Maybe its because of data-app attribute:

 <meta property="twitter:app:name:googleplay" name="twitter:app:name:googleplay" content="Pinterest" data-app>

from iframely.

panzi avatar panzi commented on June 24, 2024

Yeah I also noticed the data-app attribute. This is valid HTML5, but completely invalid XML. I'll do the porting to node-htmlparser2 later (in a couple of hours).

from iframely.

panzi avatar panzi commented on June 24, 2024

Erm, what should happen when I run forever start ./modules/test-dashboard/tester.js? I now have this process:

$ ~/node0.10/bin/forever start ./modules/test-dashboard/tester.js
warn:    --minUptime not set. Defaulting to: 1000ms
warn:    --spinSleepTime not set. Your script will exit if it does not stay up for at least 1000ms
info:    Forever processing file: ./modules/test-dashboard/tester.js
$ ps aux| grep node
root      1040  0.0  0.0   6960   884 ?        Ss   19:11   0:00 /usr/sbin/mcelog --ignorenodev --daemon --foreground
panzi    16805  3.2  0.4 679052 33780 ?        Ssl  22:58   0:00 /usr/bin/node /home/panzi/node0.10/lib/node_modules/forever/bin/monitor ./modules/test-dashboard/tester.js
panzi    16817  0.0  0.0 109256   884 pts/2    S+   22:59   0:00 grep --color=auto node

But it doesn't seem to do anything. (No CPU or IO usage.) What am I supposed to do now? I did uncomment the tests section in config.local.js. There is something about mongodb. Do I need to install and run mongodb? Does it need some special configuration? If so, why haven't I got an error about this?

from iframely.

nleush avatar nleush commented on June 24, 2024

Yes, mongodb must be run.

Try /tests url - there should be error if no mongodb. It is test result dashboard, and also there are buttons to run tests for one plugin or force test plugins.
Also forever logs 0 (where 0 is index of this proccess in forever logs).

This process tests all plugins with configured periodicity, and also tests modified plugins first.

from iframely.

nleush avatar nleush commented on June 24, 2024

upd: dashboard url not /debug but /tests

from iframely.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.