GithubHelp home page GithubHelp logo

Comments (6)

iparamonau avatar iparamonau commented on July 23, 2024

thanks for reporting.
are you using /oembed or the one that is generated by iframely.js?

from iframely.

iparamonau avatar iparamonau commented on July 23, 2024

also, which browser do you use? I don't have access to IE, but Chrome, Safari and FF seem to work without those parameters http://iframe.ly/bFtk

from iframely.

iparamonau avatar iparamonau commented on July 23, 2024

Can see the issue now. Those attributes are required for flash players :\ In our tests we defaulted to html ones and could see the point of those.
Thanks for clarifying, we'll have to add it system wide, not just for Vimeo players.

While we have you Brad: would you or any other Vimeo guys be interested in helping out draft the part of Iframely embeds protocol spec, which covers the javascript/events playback? We have it intentionally left out so we can rely on experts.

The spec is at https://github.com/itteco/oembed2. Needless to say, would be amazing if Vimeo starts publishing embeds in this format too.

from iframely.

bdougherty avatar bdougherty commented on July 23, 2024

Actually, they're required for our HTML player. Without them, we won't always be able to use the HTML player and have to fall back to Flash. Thank you for the quick fix!

I'll give the spec a closer look as soon as I get a chance. I'd definitely help out with the js part. Is there a good place to start discussions?

from iframely.

iparamonau avatar iparamonau commented on July 23, 2024

thanks a lot. The spec has its own repository at https://github.com/itteco/oembed2. I've created an issue for playback (N1 of course :) ) - itteco/oembed2#1

PS. We would also need to learn some more about allowFullscreen. We added it system-wide as quick fix, but we would need to understand the details of cross-browser implementations to make a better choice. If you could point into a good detailed description of these attributes, I'll appreciate. Hard to find, apparently.

from iframely.

bdougherty avatar bdougherty commented on July 23, 2024

Here's the spec, which might be the best place: http://fullscreen.spec.whatwg.org/#fullscreen-enabled-flag
Looks like MDN also mentions all three versions: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe

Basically, it just turns on the Fullscreen API inside an iframe. The only issue would be if a website owner decides that they don't want to allow embedded content to go into fullscreen, but in our experience at Vimeo, that's hardly ever the case (we've actually gotten multiple requests to automatically put videos in fullscreen when playing).

from iframely.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.