Comments (6)
thanks for reporting.
are you using /oembed or the one that is generated by iframely.js?
from iframely.
also, which browser do you use? I don't have access to IE, but Chrome, Safari and FF seem to work without those parameters http://iframe.ly/bFtk
from iframely.
Can see the issue now. Those attributes are required for flash players :\ In our tests we defaulted to html ones and could see the point of those.
Thanks for clarifying, we'll have to add it system wide, not just for Vimeo players.
While we have you Brad: would you or any other Vimeo guys be interested in helping out draft the part of Iframely embeds protocol spec, which covers the javascript/events playback? We have it intentionally left out so we can rely on experts.
The spec is at https://github.com/itteco/oembed2. Needless to say, would be amazing if Vimeo starts publishing embeds in this format too.
from iframely.
Actually, they're required for our HTML player. Without them, we won't always be able to use the HTML player and have to fall back to Flash. Thank you for the quick fix!
I'll give the spec a closer look as soon as I get a chance. I'd definitely help out with the js part. Is there a good place to start discussions?
from iframely.
thanks a lot. The spec has its own repository at https://github.com/itteco/oembed2. I've created an issue for playback (N1 of course :) ) - itteco/oembed2#1
PS. We would also need to learn some more about allowFullscreen
. We added it system-wide as quick fix, but we would need to understand the details of cross-browser implementations to make a better choice. If you could point into a good detailed description of these attributes, I'll appreciate. Hard to find, apparently.
from iframely.
Here's the spec, which might be the best place: http://fullscreen.spec.whatwg.org/#fullscreen-enabled-flag
Looks like MDN also mentions all three versions: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe
Basically, it just turns on the Fullscreen API inside an iframe. The only issue would be if a website owner decides that they don't want to allow embedded content to go into fullscreen, but in our experience at Vimeo, that's hardly ever the case (we've actually gotten multiple requests to automatically put videos in fullscreen when playing).
from iframely.
Related Issues (20)
- Spotify Video podcast do not have the right aspect ratio HOT 1
- Missing attributes for Spotify embeds HOT 2
- Batch querying by content IDs does not work HOT 1
- Facebook public posts redirect to facebook.com/login HOT 4
- Intermittent issues with Google share links HOT 4
- Inspect Network Calls HOT 1
- AWS cli for pushing build image
- New Tumblr embeds HOT 2
- Issue with a long html page without javascripts. HOT 2
- remove racially loaded terms from the website HOT 1
- Core plugins tests are failing in Node 18 HOT 5
- Better aspect ratio for Loom embeds HOT 1
- Tweet with media are failing in self hosted version HOT 3
- Tweet with media are failing in self hosted version HOT 1
- Tweet with media are failing in self hosted version HOT 1
- Self-hosted, instagram embed, redirect loop. HOT 9
- cannot parse medium article HOT 1
- Release Schedule HOT 2
- Allow setting configuration file path via environment variable HOT 1
- Figma app link missing in self-hosted version HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iframely.