Manually build an embed from datawrapper.de about iframely

[iparamonau]

• You have href commented in your code. That was the right way to pass it as embed URL. Paired with text/html type, Iframely would no to convert it into iFrame. What you were missing is the sizing information. You could either give "aspect-ratio" in the object, or, say, just height to make the embed stretch 100% of the width. To make a fixed iFrame, you can just pass width & height.
• rel inline is the secondary rel, which is meant to indicate whether embed can be rendered via JavaScript or not. You need a main one too. I suggest [CONFIG.R.app, CONFIG.R.ssl, CONFIG.R.html5]. The flag for inline/js status isn't necessary if you return data as href rather than html. Iframely knows that iFrames are JS-friendly.
• Last but not least, in v0.8.6 we added an option to use "*" as a mixin. It adds all generic mixins, and basically means that plugin will add an embed rather than take complete control: mixins: ["*"]

[j0k3r]

I've updated the domain file with your recommandations:

module.exports = {
    re: [
        /^http[s]?:\/\/cf.datawrapper.de\/(.+?)(?:[\/](?:index\.html)?)?$/
    ],

    mixins: [
        "*"
    ],

    getLink: function(urlMatch) {
        return {
            type: CONFIG.T.text_html,
            rel: [CONFIG.R.app, CONFIG.R.ssl, CONFIG.R.html5],
            href: "http://cf.datawrapper.de/" + urlMatch[1] + "/",
            height: 350
        }
    },

    getMeta: function() {
        return {
            site: 'datawrapper',
        };
    },

    tests: [
        "http://cf.datawrapper.de/zjCKi/2/",
        "http://cf.datawrapper.de/Gx44C/21/",
        "http://cf.datawrapper.de/RrO5t/2/"
    ]
};

But it doesn't generate the iframe:

{
    "meta": {
        "title": "Montant total des amendes infligées par les régulateurs américains",
        "canonical": "http://cf.datawrapper.de/zjCKi/2/"
    },
    "links": [
        {
            "href": "http://cf.datawrapper.de/favicon.ico",
            "type": "image",
            "rel": [
                "icon"
            ]
        }
    ]
}

[iparamonau]

That would mean that domain plugin isn't called. I suggest to verify the regex, perhaps escape dots \.?
I just ran your code locally with /^https?:\/\/cf\.datawrapper\.de\/([a-zA-Z0-9]+)\//i and it works fine. Not sure if it's the correct one though.

Also, did you know there's a local debug tool at http://localhost:8061/debug ?

[iparamonau]

.@nleush mentions that your regex matches, but there might be another issue at Iframely core here.

There is a validator at Iframely core that removes embeds with iframe src = canonical address (or original URL). In your case, the urlMatch[1] would be like zjCKi/2 and you'll end up having iFrame exactly the same as URL (from your tests).

That validator is for generic parsers, especially for Open Graph. A lot of people just put og:video=canonical. Unfortunately, we can not remove this check. To work it around, you could add some query string to iFrame src, like ?for=iframely or something.

[j0k3r]

Of course I know the debug tool, I mostly used to test the domain 😉

And THANKS for that point @nleush I started to dig into the core.js to find why my regex is valid outside IFramely but not inside.

It works great now.
Thanks guys 👍

[j0k3r]

@iparamonau Should I submit a PR to add this domain in plugins?

[iparamonau]

@j0k3r Sure, would be great. Thanks!