What if there is no eyaml private key? about domed-city

[timbirk]

Furhter to the above this whole section looks a bit weird... https://github.com/ITV/domed-city/blob/master/lib/dome/hiera_lookup.rb#L36-L51

[timbirk]

Perhaps eyaml_dir would be better off named: eyaml_key_dir.

[kemra102]

@timbirk #41 add's an appropriate error message in just this situation

[dprint8]

Using domed-city 6.3.1 from https://github.com/ITV/domed-city (at v6.3.1@adfcde0) similar issue:

TypeError: no implicit conversion of nil into String
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/hiera_lookup.rb:49:in `join'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/hiera_lookup.rb:49:in `eyaml_private_key'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/hiera_lookup.rb:24:in `default_config'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/hiera_lookup.rb:13:in `config'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/hiera_lookup.rb:67:in `lookup'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/hiera_lookup.rb:79:in `block in secret_env_vars'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/hiera_lookup.rb:78:in `each_pair'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/hiera_lookup.rb:78:in `secret_env_vars'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/secrets.rb:16:in `secret_env_vars'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/lib/dome/terraform.rb:34:in `plan'
  /Users/DimiPrin/.gem/ruby/2.3.1/bundler/gems/domed-city-adfcde061943/bin/dome:30:in `<top (required)>'
  /Users/DimiPrin/.gem/ruby/2.3.1/bin/dome:23:in `load'
  /Users/DimiPrin/.gem/ruby/2.3.1/bin/dome:23:in `<top (required)>'```

[kemra102]

The exact error reported by Tim above was fixed by #41 - suspect there are a few spots with similar assumptions.

[dprint8]

@themattkeating v6.2.0 as well