language uri about starter-public-edition-4

[quasiperfect]

sorry to reopen this again but if you have more then one application(with language uri) won't work

for site app you have domain.com/en/controller/method/etc
for test app it becomes domain.com/test/en/controller/method/etc instead of domain.com/en/test/controller/method/etc

or this is intended behavior ?

[ivantcholakov]

http://domain.com/test/ is the base URL of the application. After it the language identificator comes. I don't see a problem.

http://domain.com/en/test/ - actually with this URL you will get into the default application.

I suppose, inside .htaccess you may try to translate /test/en/ -> /en/test/ , but I don't see a serious reason why is that necessary, especially when the second application is for administration purposes.

[quasiperfect]

in terms of application i was thinking more like

site app - cms
forum app - forum
admin - admin

so domain.com/en/forum is nicer then domain/forum/en/

guess i will have to keep forum as a module inside site app

i will try to get a solution for this because i like the idea of multiple (more then 2) applications

[ivantcholakov]

Better don't make the forum as a separate application. It can be a module, why not. If you generate sitemap.xml this would be easier for one public application. Also, when a user logs in the site, all the special features for a logged user, including in the forum would be accessible. You will avoid some duplicate efforts for visual design.

With this particular platform I have no a real site yet. It would happen at the end of this year. I see the following picture:

http://example.com/ - the public site
http://example.com/admin/ - the administration site
http://example.com/services/ - web services (RESTfull maybe), for banner exchange, advertizing, etc.

---

http://example.com/en/module/controller/method
http://example.com/application2/en/module/controller/method
http://example.com/application3/en/module/controller/method

This is what I intend to stay as a default behavior. Also, I implemented the language URI only for the default application intentionally. If you want this for all the applications you can port corresponding code within the platform/core/common/ folder.

[quasiperfect]

ok no problem i will implement my own solution

on question i tried to get lang in core_config

$CI =& get_instance();
if (isset($CI->lang) && is_object($CI->lang)) {}

the condition fails any way to load lang lib ?

should i just add the relevant code in my_config and my_lang files (inside platform\core\common\core) or core_config and core_lang ?

[ivantcholakov]

The original fragment was:

        if (function_exists('get_instance'))        
        {
            $CI =& get_instance();
            $uri = $CI->lang->localized($uri);            
        }

https://github.com/EllisLab/CodeIgniter/wiki/CodeIgniter-2.1-internationalization-i18n

I suppose, this check is necessary, because site_ulr() might be called before the core has been fully loaded.

Due to my rearrangement in the bootstrap code and to suppress the error "calling a method of non-object", I extended this check this way:

        if (function_exists('get_instance'))        
        {
            $CI =& get_instance();

            if (isset($CI->lang) && is_object($CI->lang)) {
                $uri = $CI->lang->localized($uri);
            }
        }

When the core is loaded at certain stage, the condition does not fail and $uri = $CI->lang->localized($uri); gets callable.

I recommend for the moment you just to copy/paste language URI relevant code to the relevant applications that require this feature. I know, this is ugly.

It would be good this code to be integrated within the common "application", but additional setting for enabling/disabling this feature is required then. I don't like these hard-coded settings in the original code - some new configuration options should be created. When I have time, I'll polish this code and I'll move it within the common "application".

[quasiperfect]

ok thanks a lot and sorry to be a bore

[ivantcholakov]

No problem at all.

[ivantcholakov]

@quasiperfect
I reworked internationalization totally, I think, its quality is good now.