GithubHelp home page GithubHelp logo

Q: merge with another project about masscan HOT 2 CLOSED

ivre avatar ivre commented on July 2, 2024
Q: merge with another project

from masscan.

Comments (2)

mzpqnxow avatar mzpqnxow commented on July 2, 2024 2

@gulldan you can reference this to understand the reasoning behind that response:

#1 (comment)

Most of the commits to that fork (as far as I can tell) are small changes/refactors that touch many lines of code without adding any runtime value

I love "correct" code but not when it adds cost somewhere else. In this context, those commits only serve to make it more difficult to keep in sync with upstream, which in turn makes it more difficult to cherry-pick features/bug-fixes to/from upstream

from masscan.

p-l- avatar p-l- commented on July 2, 2024

Thanks for the heads up. Overall I don't think it matches our needs & expectations; for example the commit history is super hard to follow.

from masscan.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.