GithubHelp home page GithubHelp logo

Comments (3)

felixxm avatar felixxm commented on May 17, 2024

Fix is quite straightforward:

diff --git a/rest_framework_datatables/filters.py b/rest_framework_datatables/filters.py
index 0cbb7a9..9e9a6d8 100644
--- a/rest_framework_datatables/filters.py
+++ b/rest_framework_datatables/filters.py
@@ -14,7 +14,7 @@ class DatatablesFilterBackend(BaseFilterBackend):
         if request.accepted_renderer.format != 'datatables':
             return queryset
 
-        total_count = queryset.count()                                                                                                                
+        total_count = view.get_queryset().count()                                                                                                     
         # set the queryset count as an attribute of the view for later                                                                                
         # TODO: find a better way than this hack                                                                                                      
         setattr(view, '_datatables_total_count', total_count)

from django-rest-framework-datatables.

izimobil avatar izimobil commented on May 17, 2024

Hi,
good catch indeed, could you submit a PR please ?
Thanks !

from django-rest-framework-datatables.

felixxm avatar felixxm commented on May 17, 2024

Yes I will

from django-rest-framework-datatables.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.