GithubHelp home page GithubHelp logo

Comments (3)

izimobil avatar izimobil commented on May 17, 2024

Hi @TauPan, I'm not sure if we should drop python 2... Maybe, what's really blocking ?

from django-rest-framework-datatables.

TauPan avatar TauPan commented on May 17, 2024

This is really about #72

To make django-filter support truly optional, I'm currently skipping all the django-filter tests if django-filter is not available. This is easy to do with Python 3 but very hard and ugly in Python 2. See https://stackoverflow.com/questions/12487532/how-do-i-skip-a-whole-python-unittest-module-at-run-time for possible solutions.

Maybe you have a better idea how to accomplish this.

I did not make any python 2 incompatible changes to the main code (i.e. without django-filters), which means that the python 2 based tests still work, but I get two errors when SkipTest is raised.

The other problem I have is that django-filters changed their api in >= 2.2.0 and they dropped python 2 support at the same time. Maybe my changes are compatible with an older version of django-filter that still supports python 2. I'd have to give it a try.

Do you happen to know if there are active projects using django-rest-framework-datatables that are still python 2 based?

from django-rest-framework-datatables.

izimobil avatar izimobil commented on May 17, 2024

I have merged #72 manually, so we will drop python 2 support on 0.6.0 release.

from django-rest-framework-datatables.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.