Update for Atom 0.121 about atom-pdf-view

[izuzak]

Thanks for the bump, just published version 0.9.0 with the fix for Atom 0.121.0

[aengelke]

Sorry, I just updated pdf-view and get this message after start up from the incompatible packages view:

[email protected] - Error message: no errorc:\Users\aengelke\.atom\packages\pdf-view\node_modules\pathwatcher\node_modules\runas\build\Release\runas.node

[izuzak]

@aengelke Sorry, I'm not seeing that problem.

Can you share more details please? Which version of Atom are you using? Have you tried uninstalling pdf-view completely and then re-installing?

[aengelke]

I'm using Atom 0.121. One problem with the pathwatcher package were some warnings (see issue atom/node-pathwatcher#38). With disabling WarnAsError, it all compiles fine. The runas module compiles without any errors or warnings. And yes, it is a re-install after removing the old version of pdf-view.

The installation through apm doesn't work at all, since pathwatcher won't compile without a tweak (see above).

Edit: I have VS 2010 installed. Even replacing pathwatcher and runas with the versions shipped with atom doesn't help.

[izuzak]

Interesting, thanks for the details. Just to make sure -- does the same problem happen on 0.123.0?

Also, from what you're saying (and I might be misunderstanding) -- this is an issue with node-pathwatcher? Do you have a suggestion how this package might work around this build problem in node-pathwatcher?

[kenowessels]

I got this error message after updating to Atom 0.123.0

trying to update PDF-View is failing:

[aengelke]

@izuzak This still happens with 0.123.0, nan now gives a warning (c4244). Actually, it is not an issue with this package, as other packages have the same issues. A temporary work around: don't use node-pathwatcher. (How to detect file changes then?)

Edit: I tweaked my pdf-view to work without the pathwatcher module, and added a pdf-view:reload command to trigger the reload manually.