jackstouffer / stdxdecimal Goto Github PK

I think you should consider to switch sign from (0,1) to -1; 1, using an enum to improve readibilityand a function helper.
It seems you just use -1;1 for coefficient.

I read:

sign = val >= 0 ? 0 : 1;

and

sign = val < 0 ? 0 : 1;

With 1;-1 you can write:

enum Sign : ubyte { POSITIVE = 1; NEGATIVE = -1; }
ubyte getSign(T)(T n) { n >= 0?Sign.POSITIVE:-Sign.NEGATIVE; }
// first case
sign =  getSign(val);
// Second case
sign = -getSign(val);

This seems less error-prone that inverting bool conditions, and you can use also sign to get some calc, of course.

This package is going to be very useful to me an I really appreciate your doing it. There is this package which does something similar so I though you could use some inspiration from it (especially those convenience functions/methods it provides). D has the ability to let your modify the behavior of operators so not all might make sense to implement as a convenience function/methods though.

Here at https://github.com/MikeMcl/decimal.js/