Enhancing User Experience with Distinctive External Link Indicators and Automatic New Tab Opening about quartz

[tuta-amb]

Alright, I'm going to take a shot at this issue.

Also, I don't believe that external links (or any, for that matter) open in a new tab.

[jackyzha0]

It is considered bad practice to open links in new tabs by default, this should be user defined: #127

[tuta-amb]

I've gotten the icon to successfully be added, but due to my terrible knowledge of CSS (I'm a backend developer lol), I can't for the life of me the SVG to fit nicely inline. It also doesn't respect the CSS variable var(--dark) for stroke color either.

ugh

Here's the JS and CSS.

[jackyzha0]

You should be able to do this purely via CSS, you don't need any additional JS here

[tuta-amb]

@jackyzha0 Is that so? Again, I suck at CSS, but I'm not aware of anything that would let me add an SVG to an element.

[jackyzha0]

see: https://stackoverflow.com/questions/5379752/css-style-external-links

[jackyzha0]

also you can/should just use content: with one of these: https://gist.github.com/miguelmota/322c89234d60de578f37d3c6d30f7e41

[tuta-amb]

@jackyzha0 Okay, thanks. I'll look into these tommorow, it's one in the morning for me now. :]

[xy-241]

Alright, I'm going to take a shot at this issue.

Also, I don't believe that external links (or any, for that matter) open in a new tab.

Yup, I think opening external link in a new tab improves the user experience

[xy-241]

It is considered bad practice to open links in new tabs by default, this should be user defined: #127

I see, makes sense. Thanks for the info.