Go-kit logger implementation about jaeger-client-go

[yurishkuro]

do you have it written already? I'd be curious to see it first, just as a paste.

[sagikazarmark]

Nothing special really:

// kitLogger wraps the application logger instance in a Jaeger compatible one.
type kitLogger struct {
	logger log.Logger
}

// Error implements the github.com/uber/jaeger-client-go/log.Logger interface.
func (l *kitLogger) Error(msg string) {
	level.Error(l.logger).Log("msg", msg)
}

// Infof implements the github.com/uber/jaeger-client-go/log.Logger interface.
func (l *kitLogger) Infof(msg string, args ...interface{}) {
	level.Info(l.logger).Log("msg", fmt.Sprintf(msg, args...))
}

Needs a constructor and exporting a few bits. It would probably make sense to call level.* once and store the two leveled loggers.

Another feature could be changing the message key, as in case of the go-kit stdlog wrapper.

[yurishkuro]

Thanks. I wonder if it could be added simply as a recipe somewhere in the docs rather than part of the library, because it can't compile without requiring a dependency on go-kit. Or a separate small repo, like jaegertracing/go-client-gokit

[sagikazarmark]

Fine by me. Though the jaeger-lib package already requires the go-kit package for metrics stuff.

[yurishkuro]

@sagikazarmark that's true, but if you look at glide.lock, the only thing that gets directly imported into the client is this:

- name: github.com/uber/jaeger-lib
  version: 575c678b2873b62aaadd0fa5817a2aeb3155dc4d
  subpackages:
  - metrics
  - metrics/testutils

The go-kit is not imported unless the end-user project wants to use its bindings.

My suggestion is to put your code into a github gist and submit a PR to this project with an update to README mentioning that there's the binding for go-kit.

[sagikazarmark]

Which do you think would be better? A gist or a separate repo.

While I'm all for copying small amount of code which just works and never needs to be modified, one would prefer an installable package. A repo would let the user choose (copy/install) and we could write tests (even if that doesn't add much).

[yurishkuro]

another option is to put this into jaeger-lib, e.g. in client/log/gokit

[sagikazarmark]

Works for me too. Should I open a PR there?

…

On Sep 19, 2017 18:47, "Yuri Shkuro" ***@***.***> wrote: another option is to put this into jaeger-lib, e.g. in client/log/gokit — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#200 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABK2kA1q7XmqgVlg2WQPgJuMCG4CIVH6ks5sj_AKgaJpZM4PaV6S> .

[yurishkuro]

yes, please

[sagikazarmark]

Done, see PR above.

[yurishkuro]

once that PR is merged, we should make an entry in the README here

[sagikazarmark]

Should I add a note in the readme?

[yurishkuro]

yes please