Comments (8)
@yurishkuro any thoughts here?
It seems that we should be able to curl an application without needing an explicit tracing header.
from jaeger-client-go.
The way I would approach it is similar to jaeger-debug-id
, i.e. define a standard header like jaeger-baggage
that will copy the baggage into the root span. Some decisions to make about it is the format of the value, e.g.
jaeger-baggage: key=value,key=value,key=value
from jaeger-client-go.
@yurishkuro How do you feel about adopting http query strings ( e.g jaeger-baggage: key1=value1&key2=value%20two
) as the header value format instead?
I feel that query strings are relatively more standard, and are understood by more things than the format you suggested.
from jaeger-client-go.
the comma-separated list is how HTTP defines repeated headers, that is when we iterate through the headers we might get the same header repeated, or the value can be a comma-separated list. So that leaves just the question of key=value
separation, which is the same in both representations.
from jaeger-client-go.
I see, I wasn't aware of that.
Another option is doing something similar to how we inject headers for propagation, i.e having a header value prefix
jaeger-baggage-key1: value1
jaeger-baggage-key2: value2
from jaeger-client-go.
I think you're overcomplicating it. I consider sending curl request with baggage to be a very marginal use case to begin with, not to mention doing it with more than one baggage item. Comma-separated string works for that, and actually simpler to use than numbered headers, both for sending and for reading.
from jaeger-client-go.
You are right, let's stick to the original suggestion
from jaeger-client-go.
Fixed by #49, released as 1.6
from jaeger-client-go.
Related Issues (20)
- New release 2.26 HOT 2
- go get v2.26.0 checksum mismatch HOT 8
- RemotelyControlledSampler.Close() stuck due to networking issues HOT 1
- Probabilistic sampler causes trace collisions HOT 1
- Import of "testing" package HOT 4
- Issue found by Svace static analyzer HOT 1
- codahale/hdrhistogram has transferred it's repo
- Span.SetTag does not behave like the opentracing Span interface docs
- consider add more verbosity to error for http span sender
- make install always downloads linux version of 'dep' HOT 1
- A Questions about sampling rate HOT 2
- Connecting jaegertracing-client-go from WSL2
- Suggest to support zipkin mode (and additional baggage prefix) from environment variable
- 128 bit mode should be default HOT 5
- sampler logger is NullLogger
- [Bug]: writeField5 panic
- [Bug]: Sampler tags are missing in root span generated from startSpan
- [Bug]: Performance impact of sprintf HOT 1
- [Bug]: mismatched parameters HOT 1
- [Bug]: `config.Configuration.InitGlobalTracer` panics if `http.DefaultTransport` is not a `*http.Transport`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jaeger-client-go.