GithubHelp home page GithubHelp logo

Comments (8)

blampe avatar blampe commented on May 24, 2024

@yurishkuro any thoughts here?

It seems that we should be able to curl an application without needing an explicit tracing header.

from jaeger-client-go.

yurishkuro avatar yurishkuro commented on May 24, 2024

The way I would approach it is similar to jaeger-debug-id, i.e. define a standard header like jaeger-baggage that will copy the baggage into the root span. Some decisions to make about it is the format of the value, e.g.

jaeger-baggage: key=value,key=value,key=value

from jaeger-client-go.

vprithvi avatar vprithvi commented on May 24, 2024

@yurishkuro How do you feel about adopting http query strings ( e.g jaeger-baggage: key1=value1&key2=value%20two) as the header value format instead?
I feel that query strings are relatively more standard, and are understood by more things than the format you suggested.

from jaeger-client-go.

yurishkuro avatar yurishkuro commented on May 24, 2024

the comma-separated list is how HTTP defines repeated headers, that is when we iterate through the headers we might get the same header repeated, or the value can be a comma-separated list. So that leaves just the question of key=value separation, which is the same in both representations.

from jaeger-client-go.

vprithvi avatar vprithvi commented on May 24, 2024

I see, I wasn't aware of that.
Another option is doing something similar to how we inject headers for propagation, i.e having a header value prefix

jaeger-baggage-key1: value1
jaeger-baggage-key2: value2

from jaeger-client-go.

yurishkuro avatar yurishkuro commented on May 24, 2024

I think you're overcomplicating it. I consider sending curl request with baggage to be a very marginal use case to begin with, not to mention doing it with more than one baggage item. Comma-separated string works for that, and actually simpler to use than numbered headers, both for sending and for reading.

from jaeger-client-go.

vprithvi avatar vprithvi commented on May 24, 2024

You are right, let's stick to the original suggestion

from jaeger-client-go.

yurishkuro avatar yurishkuro commented on May 24, 2024

Fixed by #49, released as 1.6

from jaeger-client-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.