Comments (5)
In GitLab by @oliveroxtoby on May 10, 2022, 21:21
requested review from @icojb25
from cfdof.
In GitLab by @icojb25 on May 11, 2022, 24:49
added 1 commit
- 8d86c9b - Change scalar field name in template to match filename as well
from cfdof.
In GitLab by @icojb25 on May 11, 2022, 24:57
Thanks for the fix to the field name.
- If we are allowing the field name to change (which is cool), we could now allow multiple STF's per simulation as well, so I dont know if we want to remove that restriction now as well
Agreed - I hadn't noticed, but we should do that.
- If the user is using the multiphase physics, would that not make the phase restriction option valid?
Fair enough, I'll add it back. It would be nice if it was a dropdown of valid phase names like we have in the init fields dialog (for example) rather than free-form text.
- Since 1), do we want to somehow restrict users from entering field names which would clash with existing fields, like U, p or T? Or is it caveat emptor (!)
Good point. Maybe caveat emptor for now, but it would be good if we had a more formal list we can query of which solvers and turbulence models use which fields. Something like a dictionary with information for each solver name (e.g. whether it uses kinematic or dynamic pressure, which fields it involves, etc.) would make the code cleaner.
I cant see where you're re-writing the file name, but thats pretty cool.
It's this feature of the template builder - also used for giving the alpha fields the correct name: https://gitlab.com/opensimproject/cfdof/-/blob/develop/data/defaults/_Readme.md#L59
from cfdof.
In GitLab by @oliveroxtoby on May 11, 2022, 21:07
added 1 commit
- 615ba22 - Re-enable phase-restricted scalar transport; allow multiple scalarTransport objects
from cfdof.
In GitLab by @icojb25 on May 12, 2022, 01:13
Nice addition to the workbench @oliveroxtoby
from cfdof.
Related Issues (20)
- Update initialise icon to svg - [merged]
- Feature/add probes function objects - [merged]
- Move reporting functions blurb to external file - [merged]
- Update controldict - [merged]
- Feature/add scalar transport function - [merged]
- Add DES capabilities to Physics page, add readout's of LES vs RANS zones in... - [merged]
- Fix truncated method name - [merged] HOT 4
- Merging DynamicMeshDict hotfix into dev - [merged] HOT 2
- Deselect LES or DES if selected and transient sim is unselected - [merged] HOT 2
- Feature/add srf option HOT 23
- Enable writing DES regions to file for postprocessing - [merged] HOT 2
- Draft: Update readme and changelog - [merged] HOT 3
- Makes it possible to save custom material - [closed]
- Create save option for custom material - [merged] HOT 1
- use "from CfdOF.Solve.CfdRunnableFoam import CfdRunnableFoam" - [merged] HOT 2
- Fix wrong meshDir when InputCaseName has multiple directory levels - [merged] HOT 4
- Add PurgeWrite property to control how many time dirs will be kept - [merged] HOT 8
- CfdOF not responding. Running demos and simple model. HOT 8
- Read patch data HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cfdof.