QoL Improvement: Make CfdAnalysis' "Output Directory" dynamic based on the Project Name, instead of "/tmp/case" as default about cfdof

[oliveroxtoby]

This is a good idea. I'll try to put it in soon, or you're welcome to submit a pull request.

[oliveroxtoby]

hi @oliveroxtoby I am nearly finished this implementation, however notice that in CfdPreferences.py, the function loadSettings() is actually never called, which is kind of weird. One would assume this is used to persist the changes (not working for this Feature Request yet, assume because of this).

It's not called by CfdOF but it is called by FreeCAD when the preferences page is loaded.

[eduncan911]

@oliveroxtoby nice! as a follow-up, I dove deep into FEM recently. And, it has everything I mentioned above as well as "smarter than me" logic with even more options.

Maybe follow this Workbench?

The "Custom directory" option being the same as CfdOF's Properties View current option.

But note the other two dynamic ones. I especially like the "beside FCStd file" option.

[eduncan911]

There's also something else... the FEM workbench also defaults to "search in known binary directories" for all the dependencies, instead of requiring their location.

This makes the FEM workbench work out of the box with CAE Linux - since everything is installed. For CfdOF, I have to go find each binary and specify them.

Just some suggestions to improve the the user's experience. :)

[icojb25]

hi @oliveroxtoby any idea what the call is to get the project base label is? Is this accessible via the obj passed to the CfdAnalysis.py class?

def makeCfdAnalysis(name):
""" Create a Cfd Analysis group object """
obj = FreeCAD.ActiveDocument.addObject("App::DocumentObjectGroupPython", name)
CfdAnalysis(obj)

[oliveroxtoby]

hi @oliveroxtoby any idea what the call is to get the project base label is? Is this accessible via the obj passed to the CfdAnalysis.py class?

FreeCAD.ActiveDocument.Label ?

[oliveroxtoby]

But note the other two dynamic ones. I especially like the "beside FCStd file" option.

@icojb25 just a note in case you end up implementing this aspect of it. CfdOF does currently store files in this location if the user enters a relative path in the analysis object properties - see CfdTools.getOutputPath(). So probably this code can be reused.

[oliveroxtoby]

There's also something else... the FEM workbench also defaults to "search in known binary directories" for all the dependencies, instead of requiring their location.

This makes the FEM workbench work out of the box with CAE Linux - since everything is installed. For CfdOF, I have to go find each binary and specify them.

@eduncan911 CfdOF does actually have default locations for the dependencies, which are searched if no location is given on the Preferences page. However I don't know what these are for CAE Linux, so if you could supply these we can simply add them to the defaults.

[icojb25]

But note the other two dynamic ones. I especially like the "beside FCStd file" option.

@icojb25 just a note in case you end up implementing this aspect of it. CfdOF does currently store files in this location if the user enters a relative path in the analysis object properties - see CfdTools.getOutputPath(). So probably this code can be reused.

Hi @oliveroxtoby i can chip away at it over the week. Do we want to add these options in the Preferences panel?

[oliveroxtoby]

Hi @oliveroxtoby i can chip away at it over the week. Do we want to add these options in the Preferences panel?

Thank you, that would be great.I don't think we need to have the distinction between custom directory and tmp directories (I think we can just have the custom directory defaulting to tmp directory as we do now), but adding an option in preferences like the 'Beside .FCStd file' one would be nice. And then also saving in a subdirectory with the name of the document label, as the first post alludes to.

[icojb25]

hi @oliveroxtoby
I am nearly finished this implementation, however notice that in CfdPreferences.py, the function loadSettings() is actually never called, which is kind of weird. One would assume this is used to persist the changes (not working for this Feature Request yet, assume because of this).

Can you confirm? I dont see this method called anywhere in the code ... yet it seems to be the persistence method that should be used.

[icojb25]

@eduncan911 @oliveroxtoby Take a look at this and see if it works as intended. Enjoy the long weekend.

[eduncan911]

@eduncan911 @oliveroxtoby Take a look at this and see if it works as intended. Enjoy the long weekend.

Apologies for the delay. Im between projects, so will check as soon as the next one comes!