GithubHelp home page GithubHelp logo

Comments (7)

Jake-Short avatar Jake-Short commented on August 23, 2024 1

Currently it supports online one image at a time, but adding support for albums/multiple images is on the roadmap.

from swiftui-image-viewer.

buluoray avatar buluoray commented on August 23, 2024 1

Hi, does it support albums now?

from swiftui-image-viewer.

Jake-Short avatar Jake-Short commented on August 23, 2024 1

@neodave That makes sense, thanks for taking a look! I will take your advice and try to do it without the GeometryReader.

from swiftui-image-viewer.

Jake-Short avatar Jake-Short commented on August 23, 2024

@buluoray The feature is currently being developed on the image-album-support branch. It is very buggy right now so I would wait to use it quite yet, but that branch is where you can check out the development.

from swiftui-image-viewer.

buluoray avatar buluoray commented on August 23, 2024

@Jake-Short Thanks! I checked it out. I do wish we can have something like an environmentObject to assign the images anywhere in the app to the imageViewer because I won't know what to assign at the NavigationView level but at the child views

from swiftui-image-viewer.

Jake-Short avatar Jake-Short commented on August 23, 2024

@buluoray For now, would it be possible to have an environmentObject at the root? Then you could use it for the NavigationView and could change/update it from all of the child views.

from swiftui-image-viewer.

neodave avatar neodave commented on August 23, 2024

Hey Jake I checked out your image album branch. One thing that stood out to me is your use of a GeometryReader. Because this is a framework you might run into a Reader within a Reader. We have had all kinds of problems with GeometryReaders inside of GeometryReaders. You say it is buggy, I would try refactoring the GeometryReader out and require passing in whatever geometry you need. Just a suggestion...

from swiftui-image-viewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.