Comments (7)
A reduced example of how to use Browserify with fetch loaded via npm:-
https://github.com/matthew-andrews/fetch-browserify-demo
And another with fetch loaded via bower (and debowerify):-
https://github.com/matthew-andrews/fetch-browserify-bower-demo
from fetch.
@matthew-andrews This is great. Could you create a pull request for the fetch readme that links to your examples with a little context around it? Maybe a "Using with npm" section.
from fetch.
Yup, sure — just wanted to get them working first.
from fetch.
If I understand correctly, using it with browserify will still expose it as a global. What I am concerned about is: I ship some software with github/fetch, the WHATWG Fetch API is changed, and then implemented in a browser.
Problem: if (window.fetch) return
makes my code use the native API, which is not compatible with the code I wrote.
Preferred: My code uses the version of github/fetch I had downloaded, and continues to work until I can update it to the new API. When the API is implemented in my target browsers, I can just remove my require
.
Am I missing some way of accomplishing this, or are they invalid concerns for some other reason?
from fetch.
That's a very valid point and no I don't think there's any way of accomplishing this without maintaining a fork.
I had similar feedback for https://github.com/matthew-andrews/Promise.prototype.finally, which was “if you modify the global, you'll make it harder for it to become a standard method”. I argued against it at the time: https://twitter.com/andrewsmatt/status/520987196757934080 but now I'm not so sure.
Fetch API has sort of already been implemented in browsers — although admittedly I've only seen this behind a flag in Chrome, and only via Service Workers so maybe that doesn't count.
from fetch.
@jacobrask since the entire spec is very alpha right now, I would suggest you just not use this library until things settle down.
from fetch.
Resolved by #29
from fetch.
Related Issues (20)
- 📢 🎉 We’ve made some exciting improvements to our [REST API documentation](https://docs.github.com/en/rest) and we'd love to know what you think about the new layout! Let us know 👇 HOT 1
- Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the [contributing guidelines](https://github.com/github/docs/blob/main/CONTRIBUTING.md). HOT 1
- This repository is moving from the github org HOT 2
- Owner [email protected]
- 2018 license appachie com [email protected]
- Refused to get unsafe header "set-cookie"
- Owner
- changelog is missing for latest releases HOT 1
- File fetching broken since commit 0c1d2b9 HOT 3
- Create a Security Policy HOT 1
- Enable OpenSSF Scorecard Action HOT 3
- `Set-Cookie` headers should not be combined / Support `Headers.getSetCookie()` method
- Hash pin actions used on workflows and enable depenadabot
- code is working in chrome, not in firefox HOT 2
- Overriding feature detection HOT 2
- suggestion to use str.indexOf(searchString) === 0 for better compatibility HOT 2
- UMD Releases don't exist HOT 1
- Linkedin uses status code 999 which leads to RangeError HOT 4
- Response does not resolve until body fetched
- Response.body is always undefined
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fetch.