GithubHelp home page GithubHelp logo

Comments (11)

JakeWharton avatar JakeWharton commented on July 22, 2024

There are no devices running API 14.

from timber.

weitzj avatar weitzj commented on July 22, 2024

Thank you.

from timber.

dalewking avatar dalewking commented on July 22, 2024

I know that there are almost certainly no actual devices running API, this is causing us heartburn on our project and we have delayed adopting the new Timber, which we really want to do to eliminate the warnings for hardcoded strings.

The issue is that we already have printed promotional materials that say our app supports 4.0 and above, but if we set our minimum to 15 the promotional materials will be incorrect which can have legal implications.

So I agree that it is extremely unlikely that any one will ever have an API 14 device, there is also absolutely no reason to cause so much confusion among your users by stubbornly and arbitrarily choosing to set a minimum of 15 when there is no difference that matters to this library between 14 and 15.

from timber.

briangriffey avatar briangriffey commented on July 22, 2024

Why not fork and set the minsdk to 14 if you really need it?

from timber.

dalewking avatar dalewking commented on July 22, 2024

Because that means we have to build it, causing us to either set up a build process to build it and deploy it for our builds or include it as a submodule and increase our build time. Currently, we are staying with 2.x versions and not able to take advantage of the actual PR that we submitted to this project due to the ramifications of switching from API 14 to 15. Many man-hours have already been spent at my company debating this. Would you really like the task of explaining to your customer that you are no longer supporting version 14 of Android for no actual valid technical reasons, just because some 3rd party developer wants to make some stupid point about the lack of API 14 devices?

If there were a valid technical reason for not supporting 14 I would support that decision. There has already been 3 issues filed on this question in addition to me commenting on it in PR #67 where the change was introduced. I am sure there will probably be more issues filed as time goes by.

from timber.

JakeWharton avatar JakeWharton commented on July 22, 2024

It's literally one file. Copy/paste it.

On Fri, Nov 20, 2015 at 1:42 PM Boycott Github [email protected]
wrote:

Because that means we have to build, it causing us to either set up a
build process to build it and deploy it for our builds or include it as a
submodule and increase our build time. Currently, we are staying with 2.x
versions and not able to take advantage of the actual PR that we submitted
to this project due to the ramifications of switching from API 14 to 15.
Many man-hours have already been spent at my company debating this. Would
you really like the task of explaining to your customer that you are no
longer supporting version 14 of Android for no actual valid technical
reasons, just because some 3rd party developer wants to make some stupid
point about the lack of API 14 devices?

If there were a valid technical reason for not supporting 14 I would
support that decision. There has already been 3 issues filed on this
question in addition to me commenting on it in PR #67
#67 where the change was
introduced. I am sure there will probably be more issues filed as time goes
by.

ā€”
Reply to this email directly or view it on GitHub
#108 (comment).

from timber.

ahmedre avatar ahmedre commented on July 22, 2024

@dalewking as an alternative, you can add: <uses-sdk tools:overrideLibrary="timber.log" /> - to your AndroidManifest.xml - this will override Timber's minSdk with whatever you have set in build.gradle.

from timber.

dalewking avatar dalewking commented on July 22, 2024

Thank you very much @ahmedre! The other alternative I was looking at was using jitpack.io to build a forked version.

from timber.

dalewking avatar dalewking commented on July 22, 2024

FYI, our app, which does support API 14, just got a bug report for someone using 4.0.3 (LGE-P700 Optimus L7) so the statement, "There are no devices running API 14." is false. Our app is only available in Europe so that may have some influence on the choice of devices and people's tendency to update. The device does appear to have updates to 4.1.2.

from timber.

gabrielittner avatar gabrielittner commented on July 22, 2024

4.0.3 is already API 15

from timber.

dalewking avatar dalewking commented on July 22, 2024

Darn, I did a search and apparently the site I checked had misinformation on that

from timber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.