GithubHelp home page GithubHelp logo

Comments (4)

JakeWharton avatar JakeWharton commented on July 22, 2024

I inject it everywhere. Haven't found a place where it couldn't be passed in like any other dependency yet. Another option would be to use static injection to put it into a static field somewhere immediately when the object graph is created. Yet another, simpler option:

public static final Timber LOG = BuildConfig.DEBUG ? Timber.DEBUG : Timber.PROD;

from timber.

AlexKorovyansky avatar AlexKorovyansky commented on July 22, 2024

Hmm... I like idea inject it everywhere! Other ways looks significantly worse.

For me it's not clear how to inject timber in this case (to Binary and Telnet Connections).

 /* Low level class implemented binary async connection (in Twisted style) */
public class BinaryConnection {

   public BinaryConnection(HostAddress remoteAddress, BinaryPacketReader packetReader)

   ...

}
 /* Low level class implemented telnet async connection (in Twisted style) */
public class TelnetConnection {

   public TelnetConnection(HostAddress remoteAddress) {
        this.binaryConnection = new BinaryConnection(remoteAddress, new DelimitedPacketReader("\r\n"));

   ...

}

Any ideas?

Thank you!

from timber.

tbruyelle avatar tbruyelle commented on July 22, 2024

With the help of the new gradle build system, I integrated Timber in the BuildConfig.

Something like that :

buildTypes {
  release {
    buildConfig  "public static final timber.log.Timber LOGGER = timber.log.Timber.PROD;"
  }
  debug {
    buildConfig  "public static final timber.log.Timber LOGGER = timber.log.Timber.DEBUG;"
  } 
}

from timber.

JakeWharton avatar JakeWharton commented on July 22, 2024

@tbruyelle Clever!

@korovyansk If you can't inject directly, you need to manually pass around an instance that's injected in a class higher up. You can also use static injection to get it in a static field accessible everywhere.

from timber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.