GithubHelp home page GithubHelp logo

Add localheinz's PHPStan rules about toolbox HOT 5 CLOSED

dkarlovi avatar dkarlovi commented on September 28, 2024
Add localheinz's PHPStan rules

from toolbox.

Comments (5)

jakzal avatar jakzal commented on September 28, 2024

I'd be careful with adding too many extensions. Currently the build is failing due to one of them: https://travis-ci.com/jakzal/toolbox/jobs/170814684#L959

I think it's best if we support well maintained (preferably official) extensions only, and let people install additional ones in their own images.

image

from toolbox.

jakzal avatar jakzal commented on September 28, 2024

So the question is, is this an extension worth supporting?

from toolbox.

jakzal avatar jakzal commented on September 28, 2024

Looks solid, so i'm 👍

from toolbox.

dkarlovi avatar dkarlovi commented on September 28, 2024

Maybe we can figure out a way to separate officially supported from unofficial? Separate namespace and unofficial tags?

The way I see it, having these extensions for PHPStan (and later Psalm, etc) will bring significant additional value to the project since they'll be a valuable part of the toolbox. I see value in having a workflow ready which expects for them to trail for a bit behind the official release, they should be considered "best effort" if they do.

from toolbox.

dkarlovi avatar dkarlovi commented on September 28, 2024

Maybe a namespace can be phpstan-0.10 until it's updated to the latest, then it gets moved to phpstan? Something like that, you can still use it and it might even work (for you), but this way you're communicated to it's not yet up to date.

from toolbox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.