GithubHelp home page GithubHelp logo

Comments (7)

jam3sward avatar jam3sward commented on August 19, 2024

I was able to reproduce the same issue here with a Release x64 build on Windows 10 Pro x64, so this is a confirmed bug.... to be investigated.

from quadifier.

jam3sward avatar jam3sward commented on August 19, 2024

After some investigation, I found that GetProcAddress is returning a valid pointer,
but Mhook_SetHook fails at this line:
/quadifier/win32/module/source/main.cpp#L556

MHook is a third-party library, so it's possible there might be an updated version with bug-fixes here. Further investigation is needed..

from quadifier.

jam3sward avatar jam3sward commented on August 19, 2024

I've just tried the latest MHook and the issue is still present, so unfortunately I'm not sure how to fix this, without debugging MHook itself.

from quadifier.

RichardCNN avatar RichardCNN commented on August 19, 2024

Hi,James
I get it.
the function name of "GetProcAddress" in kernel32.dll has changed on win10.
it is still reserved in KERNELBASE.dll. so just take replace kernel32.dll with kernelbase.dll. the bug will be solved.

module -> main.cpp code:
PFNGetProcAddress real_GetProcAddress = reinterpret_cast(
GetProcAddress( GetModuleHandle(L"kernelbase"), "GetProcAddress" ) );

from quadifier.

jam3sward avatar jam3sward commented on August 19, 2024

Hi Richard
Thanks, that's interesting! Last night I looked at both the 32-bit and 64-bit versions of kernel32.dll using depends.exe and GetProcAddress appears in both DLLs (with different ordinals, but the same name/decoration). Also, GetProcAddress was returning a valid pointer for kernel32/GetProcAddress, but failing at Mhook_SetHook, so I assumed the problem was there.
I'll take a look at kernelbase and the change as suggested above. Thanks!
James

from quadifier.

jam3sward avatar jam3sward commented on August 19, 2024

I've committed an attempted fix for this at c0e81b0, and tested on Windows 10 x64. This hasn't been tested on Windows 7 at time of writing.

from quadifier.

jam3sward avatar jam3sward commented on August 19, 2024

I'm closing this as it works for me now.

from quadifier.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.