GithubHelp home page GithubHelp logo

Release of version 2.1.0 about james HOT 12 CLOSED

nerdbeere avatar nerdbeere commented on May 25, 2024
Release of version 2.1.0

from james.

Comments (12)

jrmykolyn avatar jrmykolyn commented on May 25, 2024 3

Thanks to everyone for bringing me on board as org. member and collaborator.

I haven't been on the team long enough to speak to the electron-related issues that @mitchhentges is referencing (although I've seen them mentioned in other PRs), but, on a personal note, I'd be happy the crash fix go out into the wild.

from james.

mitchhentges avatar mitchhentges commented on May 25, 2024 1

Dependencies have been updated as part of #387, and I'm happy with the bugfixes and perf improvements. I think after release testing we should be "green across the board" for release

from james.

mitchhentges avatar mitchhentges commented on May 25, 2024 1

Added documentation for running upgrade tests

"Passes upgrade test" checklist:

  • Windows
  • Linux
  • Mac

from james.

mitchhentges avatar mitchhentges commented on May 25, 2024

I remember there being some issues with electron-updater, so I'd want to ensure that we test upgrades from:

  • 2.0.0 -> 2.1.0
  • 2.1.0 -> (dummy future version)

Other than that, this sounds awesome so that that crash issue is mitigated 👍

from james.

nerdbeere avatar nerdbeere commented on May 25, 2024

@mitchhentges not sure if I know how exactly ensure/test this properly

from james.

mitchhentges avatar mitchhentges commented on May 25, 2024

This was one of the problems 🤔

I'm a little fuzzy now, but there should be docs that explain enough for us to be able to test updates without actually updating real installations in the field (perhaps these?)
When I've got time (tomorrow probably) I want to do a pass at updating all of James' dependencies, including electron-*. When I do that, I'll peek through the electron-updater changelog and see what I can find

from james.

tomitm avatar tomitm commented on May 25, 2024

Regarding the auto-update issues @mitchhentges is talking about: I don't entirely remember the details, but #358 has some details about rolling back electron-updater to fix a Windows issue.

Looking at electron-updater's changelog, there's been a number of updates since, so it might be safe to update that dependency at this point.

I noted in the 2.0.0 release issue (#355) that auto-update is confirmed to work albeit a bit rough around the edges (otherwise I would've held off), so releasing shouldn't be an issue. :shipit:

from james.

mitchhentges avatar mitchhentges commented on May 25, 2024

We have changed the version of electron-updater since 2.0.0 (to 2.19.0 from 2.16.3), so we'll either want to:

  • Update electron-updater some more, and re-test updating
  • Downgrade to 2.16.3 so we can deploy 2.1.0 without fear of breakage

from james.

mitchhentges avatar mitchhentges commented on May 25, 2024

Having issues testing on mac - you can see the error on sentry

Could not get code signature for running application

🤔 not sure how to work around this yet

from james.

mitchhentges avatar mitchhentges commented on May 25, 2024

I couldn't find a nice way of working around this - @nerdbeere, would you be able to do an upgrade test on Mac? I've got docs available here 😄

from james.

mitchhentges avatar mitchhentges commented on May 25, 2024

I'm going to do a pre-release build via Travis, so I can get signed builds.
If those upgrade from our last pre-release (2.0.0-beta.3) then I'll consider it ready for release 😄

from james.

mitchhentges avatar mitchhentges commented on May 25, 2024

Release complete! Had an issue with exceptions being triggered when spooling up HTTPs, but I've released v2.1.1 to resolve that

from james.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.