Comments (2)
Thanks for reaching out. The behavior that you're observing is currently an intentional design choice in FlatSharp. The root of the reason for this choice is the way that FlatSharp defines Unions:
public struct Weapons : IFlatBufferUnion<Sword, Sword, Halberd>
{
// Constructor for 'Claymore'
public Weapons(Sword sword) { }
// Constructor for 'Rapier'.
public Weapons(Sword sword) { }
public Weapons(Halberd halberd) { }
}
Unfortunately, this means that the C# compiler can't distinguish between the constructors for Claymore
and Rapier
. So, Flatsharp emits this error before the C# compiler can emit a more confusing error.
Now, there are some other approaches that might work, but they would be breaking changes. For example:
public struct Weapons : IFlatBufferUnion<Sword, Sword, Halberd>
{
public static Weapons NewRapier(Sword s) { }
public static Weapons NewClaymore(Sword s) { }
public static Weapons NewHalberd(Halberd h) { }
}
I think this is worth revisiting the next time I do a major revision to FlatSharp, but I take breaking changes really seriously, so I want to be thoughtful about it.
In the meantime, Wouldn't it be logical for your Sword struct to have a type?
enum SwordKind : ubyte {
Rapier = 0,
Claymore = 1,
}
struct Sword {
damage: int32;
material: Material;
kind : SwordKind;
}
from flatsharp.
Thank you for the support and clarifications.
I'll think of an alternative solution in the meantime.
from flatsharp.
Related Issues (20)
- Implementation of IInputBuffer for ReadOnlySequence<byte> HOT 6
- Share table HOT 2
- [Bug] Using the latest "Standalone" `FlatSharp` nuget in a .net6 project; generates a file that requires `IPoolableObject` HOT 2
- Reducing compiler generated file HOT 15
- Duplicate fbs filenames in different folders break compilation HOT 2
- Getting TypeLoadException when trying to access FlatSharp types HOT 9
- Shared fbs between multiple projects HOT 11
- [Bug] Flatsharp can't compile schemas on seperate drives HOT 7
- Warnings with new shared project feature HOT 3
- AOT exception when running a game built with Unity 2021.3 IL2CPP HOT 3
- Don't use Nullable properties for GreedyMutable only serializers HOT 4
- Allow fbs fs_serializer attribute to override global code gen settings HOT 2
- Serialization in V7 HOT 1
- Error generating model code when using namespace ending with FlatBuffer in .fbs file HOT 2
- flatsharp.compiler 7.x requires net6.0 SDK HOT 5
- Version conflict detected for Microsoft.CodeAnalysis.Common HOT 2
- Issue with init-only property when generating FlatSharp schema in .NET 6 HOT 2
- Clean up Exceptions Thrown in Generated Code
- NativeArray<T>' exists in both UnityEngine.CoreModule
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flatsharp.