GithubHelp home page GithubHelp logo

Comments (9)

jamesplease avatar jamesplease commented on June 15, 2024

yo @kilbot. I'll definitely be updating it to work for version 2 sometime. I've just been a bit busy!

With that said, do note that this was only ever a prototype. I wouldn't recommend that anyone use this in production unless they write their own test suite for it!

from marionette.transition-region.

kilbot avatar kilbot commented on June 15, 2024

Great, thanks for reply! I just started playing with animated regions today ... I figure I might as well start down the right track :) Thanks again!

from marionette.transition-region.

jamiebuilds avatar jamiebuilds commented on June 15, 2024

This can probably be left open as a reminder to update it.

from marionette.transition-region.

jamesplease avatar jamesplease commented on June 15, 2024

Updated to v2 ~

from marionette.transition-region.

kilbot avatar kilbot commented on June 15, 2024

Thanks @jmeas!

from marionette.transition-region.

jamesplease avatar jamesplease commented on June 15, 2024

No problem, @kilbot. I also just added support for concurrent transitions so you can now do sliding views. Do note that the code was really, really quickly written. The library really needs a rewrite before it's ever production-ready. You can see the examples on JSFiddle.

from marionette.transition-region.

kilbot avatar kilbot commented on June 15, 2024

That's great @jmeas, the sliding example is exactly what I was hoping to achieve. I understand it's not tested, but it's a great place to start for me. If I can add anything through my testing I'll try and contribute back to the project.

from marionette.transition-region.

jamesplease avatar jamesplease commented on June 15, 2024

Oh, ha, how convenient @kilbot :)

Before I made these updates, I think this TransitionRegion passed all of the 1.8.x unit tests when I patched Marionette.Region directly. If you want to know whether it's production-ready you could do the same thing for the 2.x tests.

The process should be as easy as:

  1. Clone the Marionette Repo.
  2. Add this library to the bottom of the Region source code, but modify it so that it patches Region instead of creating a new Class.
  3. Run the unit tests by running grunt

from marionette.transition-region.

jamesplease avatar jamesplease commented on June 15, 2024

p.s. I know that the comments are really dismal in the code right now. If you're having trouble figuring out what's going on, or if you'd just like to talk about this approach (or other alternatives), just shoot me a message and we can talk about it. I'm always on Gitter.

Best of luck!

from marionette.transition-region.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.