GithubHelp home page GithubHelp logo

Comments (12)

Jadiction avatar Jadiction commented on June 11, 2024 3

@Jadiction Please go ahead and test it and give me feedback.

Works good! Thank you!

To me, this looks better
image
rather than repeating the "Status update" when the information in the embed shows everything needed
image

from docker-palworld-dedicated-server.

Jadiction avatar Jadiction commented on June 11, 2024 1

WEBHOOK_ALL_TITLE will never be not set, because it goes in the Dockerfile for default-sets and Backwards-Compability.
This makes things more complicated. But when i understand you correctly you would offer:

Ah true, after thinking about it, the first solution wouldn't work, my bad. Was thinking differently.

if "isset" WEBHOOK_ALL_TITLE -> Add line and value
if "empty" WEBHOOK_ALL_TITLE -> Remove line

Yeah, this would work well. Sorry for the delay.

from docker-palworld-dedicated-server.

jammsen avatar jammsen commented on June 11, 2024 1

If you like this project, please consider giving this repo and the Docker-Hub-Repo a Star.

from docker-palworld-dedicated-server.

jammsen avatar jammsen commented on June 11, 2024

Hey @Jadiction - Should the line "content": WEBHOOK_ALL_TITLE, be removed if the ENV variable is set to empty/nothing?

from docker-palworld-dedicated-server.

jammsen avatar jammsen commented on June 11, 2024

Also please use the Prefix of titles like i set it up for FR, that helps me to stay organized.

from docker-palworld-dedicated-server.

Jadiction avatar Jadiction commented on June 11, 2024

Hey @Jadiction - Should the line "content": WEBHOOK_ALL_TITLE, be removed if the ENV variable is set to empty/nothing?

Good question, certain webhooks may require the content to be specified (even if empty).
Depending on how you'd like it, I can think of 2 solutions:

  1. If the ENV variable is specified, the line gets used (aka don't check if empty, only if set), otherwise exclude the line.
  2. To play it safe and default it to "Status update," check for the ENV variable to be "NULL" to exclude it
    if ENV var is set & not "null", include line else if the ENV variable is not empty, content = ENV var, else content = "Status update"

I understand this makes it a little specific and would need some extra explaining in the documentation, but I believe it adds customizability.

from docker-palworld-dedicated-server.

jammsen avatar jammsen commented on June 11, 2024

WEBHOOK_ALL_TITLE will never be not set, because it goes in the Dockerfile for default-sets and Backwards-Compability.
This makes things more complicated. But when i understand you correctly you would offer:

if "isset" WEBHOOK_ALL_TITLE -> Add line and value
if "empty" WEBHOOK_ALL_TITLE -> Remove line

Right? I think talking in pseudo-code is more easy to explain than very comlicated text 🤣

from docker-palworld-dedicated-server.

jammsen avatar jammsen commented on June 11, 2024

@Jadiction Ping

from docker-palworld-dedicated-server.

jammsen avatar jammsen commented on June 11, 2024

It doesnt really save space but it works:
image

Pushing it to develop and to latest later.

from docker-palworld-dedicated-server.

jammsen avatar jammsen commented on June 11, 2024

See https://discord.com/channels/532141442731212810/1209949579185881139/1211257198869749800

from docker-palworld-dedicated-server.

jammsen avatar jammsen commented on June 11, 2024

@Jadiction Please go ahead and test it and give me feedback.

from docker-palworld-dedicated-server.

jammsen avatar jammsen commented on June 11, 2024

@Jadiction all good, happy to help!

from docker-palworld-dedicated-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.