Trying to upload non-existing file hangs test suite about runner

[Julien-R44]

I don't have any problems on my side. I did npm install, then node ace test after filling my .env file.

Is there anything else to do?

[evoactivity]

Hm, I wonder if this is different on windows. I'm on a mac and the github action runs on ubuntu.
I have a windows machine I can try and report back on.

[evoactivity]

I can't recreate on windows.

[Julien-R44]

Okay thanks for testing ! I'll dust off my old mac and give it a try asap

[evoactivity]

So I tried using wtfnode to see what is keeping it alive, looks like something is using a stream/pipe but it wasn't too informative.

functional / Service Provider Profile (tests/functional/hello_world.spec.ts)
  ✔ display welcome page (224ms)
run
  ✔ upload doesn't hang (217ms)
  ✖ upload hangs (208ms)
  ✖ upload doesn't hang for full url (213ms)
^C[WTF Node?] open handles:
- File descriptors: (note: stdio always exists)
  - fd 1 (tty) (stdio)
  - fd 2 (tty) (stdio)
- Child processes
  - PID 10096
    - Entry point: node:internal/child_process:253
- Others:
  - Pipe

I've tried the latest minors of node 16 and 18.

If I comment out the this.request.attach(...) line for the file method the tests exit, so I thought the issue might be in superagent but it emits the error that the file doesn't exist as expected.
The suite:end event never seems to be emitted though.

If I use a full domain name eg

test("upload doesn't hang for full url", async ({ client }) => {
  await client
    .post(`https://example.com/`)
    .file("avatar", join(__dirname, "/does/not/exist/", "file.jpg"));
});

It will exit as expected. If I use a relative url (whether or not it exists in routes.ts) it hangs.

I have managed to narrow down the issue to this function

async runSetupCleanupFunctions() {
  console.log('runSetupCleanupFunctions this does log');
    try {
        await this.setupRunner.cleanup(this.hasError, this.suite);
        console.log('this never logs');
      }
      catch (error) {
        console.log('and neither does this');
        this.hasError = true;
        this.errors.push({ phase: 'setup:cleanup', error });
    }
}

If await this.setupRunner.cleanup(this.hasError, this.suite); is changed to this.setupRunner.cleanup(this.hasError, this.suite); it works. I don't know why.

Removing the cleanup code has no effect.

group.each.setup(async () => {
  await sleep(100);
  // return async () => await sleep(100);
});

Ok so I've landed on @adonisjs/core/build/src/TestUtils/HttpServer/index.js

close() {
    return new Promise((resolve) => this.server.instance.close(() => resolve()));
}

This never resolves.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.