Comments (3)
okay i just wrapped the
#!python
bytes = string.encode('utf-8')
from client.py @ line ~1129 in a try block like so:
#!python
try:
bytes = string.encode('utf-8')
except UnicodeDecodeError:
bytes = string
and this seamed to work at least for my first test
Original comment by: Dennis Lutter
from irc.
Hi Dennis. Yes, that is a problem. Thanks for reporting it.
I looked into the code and found no reason why the bytes should be encoded, especially for content like files. As a result, I've committed 372975319a63 which I believe addresses the issue (by providing a separate method for transmitting raw bytes).
Try it out, let me know how it works for you.
Original comment by: Jason R. Coombs
from irc.
I've released the fix as part of irc 8.5.
Original comment by: Jason R. Coombs
from irc.
Related Issues (20)
- Test regressions: irc/dict.py::irc.dict.IRCDict, irc/strings.py::irc.strings.IRCFoldedCase
- Example for creating multiple connections to a server? HOT 1
- After joining a channel, how do I get a list of usernames? HOT 1
- 'AioReactor' object has no attribute 'scheduler' HOT 3
- set_keepalive resulting into "irc.client.ServerNotConnectedError: Not connected."
- Empty quit message raises IndexError
- encoding outgoing messages seems to remove "\x1d" HOT 1
- Docs builds failing HOT 1
- IRCFoldedCase no longer folding HOT 1
- The addition of new numeric event names for SASL broke heisenbridge, which was using numeric codes. HOT 3
- SSL Support HOT 1
- `irc.connection.Factory.connect` should support `ssl.SSLContext.wrap_socket` with the `server_hostname` parameter HOT 1
- How to list channels HOT 2
- Error when attempting to join multiple channels HOT 2
- no colored or formatted text? HOT 5
- IRC Bot reconn strategy question HOT 3
- ResourceWarnings in test_reconnects_are_stable HOT 6
- How to use data from one event handler in a different one? HOT 3
- Receive public messages HOT 1
- SASL example HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from irc.