GithubHelp home page GithubHelp logo

Comments (3)

jaredhanson avatar jaredhanson commented on June 12, 2024

The audience is checked against the clientID: https://github.com/jaredhanson/passport-openidconnect/blob/master/lib/strategy.js#L173-L179

Let me know if you had something else in mind.

from passport-openidconnect.

4integration avatar 4integration commented on June 12, 2024

Hi @jaredhanson

Maybe it depends between different OIDC IdP's but the one we use; Curity (OpenId Certified); has the capability to define 0..n audience(s) and if zero audience it defaults to clientID

So think it would be good if passport-openidconnect could have an optional audience configuration that is also validated together with clientID

Like:

passport.use(new OpenIDConnectStrategy({
  issuer: `${baseUri}/token/internal/anonymous`,
  clientID: process.env.OIDC_CLIENT_ID,
  clientSecret: process.env.OIDC_CLIENT_SECRET,
  authorizationURL: `${baseUri}/token/internal/authorize`,
  userInfoURL: `${baseUri}/token/internal/userinfo`,
  tokenURL: `${baseUri}/token/internal/token`,
  callbackURL: process.env.OIDC_REDIRECT_URI,
  passReqToCallback: true,
  scope: "openid groups profile",
  audience: "urn:myorg:myapp" // <<<<<<<<<<<<<<<<<<<<<<<
},
function(req, issuer, userId, profile, accessToken, refreshToken, params, cb) {
  req.session.accessToken = accessToken;
  req.session.idToken = params['id_token'];
  return cb(null, profile);
}));

from passport-openidconnect.

jaredhanson avatar jaredhanson commented on June 12, 2024

Can you give me more details or pointers to documentation that would describe how this option would be used? I don't want to introduce and support options that have unclear semantics.

from passport-openidconnect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.