Can't make nested calls to a wrapped function about cache-manager

[BryanDonovan]

@aletorrado, I've found that if I wrap the callbacks with process.nextTick(), it solves this problem. Can you please check out branch feature/nested-cache-fetch-fix and check that I didn't break anything for your use cases? The diff is https://github.com/BryanDonovan/node-cache-manager/compare/feature/nested-cache-fetch-fix. The new unit test passes with process.nextTick change, and fails without it.

[BryanDonovan]

I'm not sure this fix is correct. It seems like magic. This line where we delete the queued callbacks: https://github.com/BryanDonovan/node-cache-manager/compare/feature/nested-cache-fetch-fix#diff-4144c5c2a16b6a217fc942aee2803138R59

.. happens before the callbacks are called. Maybe this makes sense though.

[aletorrado]

Hi @BryanDonovan. The problem was that one of the final callbacks was updating the self.queues[key] array, while iterating. Your solution is correct, but you may also want to try something like this:

    function fillCallbacks(err, data) {
        var waiting = self.queues[key];
        delete self.queues[key];
        waiting.forEach(function(task) {
            var taskDomain = task.domain || domain.create();
            taskDomain.bind(task.cb)(err, data);
        });
    }

[BryanDonovan]

Thanks, I was thinking of something similar as well. I'll give that a try.

[aletorrado]

Nice job. Thanks.