GithubHelp home page GithubHelp logo

Comments (4)

jaredwray avatar jaredwray commented on July 18, 2024

@slukes - thanks for reporting this. It looks like there has been little effort around this on handling it. I think that for right now we dont plan to fix this but if you want to come up with a solution we would love to look at it. Are you thinking that this would be an event that is fired when redis is down?

Going to close this out and if you want to create an enhancement go ahead and do a pull request.

from cache-manager.

slukes avatar slukes commented on July 18, 2024

Hello @jaredwray what I was imagining would be to:

  • add config argument of ignoreCacheErrors either to the method wrap or to caching
  • in the method wrap, surround both set and get methods in a try catch
  • in the catch, emit an event and just call the wrapped function

WDYT?

from cache-manager.

jaredwray avatar jaredwray commented on July 18, 2024

@slukes - would we want to just do the try...catch and do an event emit with error on it to keep it non invasive and simple?

from cache-manager.

slukes avatar slukes commented on July 18, 2024

Let's move this discussion to a PR 😄

from cache-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.