Comments (14)
@Kikobeats - thanks for the note and we do have a commonjs branch but it is later in the release.
Do you want to create a new one and I can look at doing a release as 7.0.3?
Let me know if you want to chat about how to do this best.
from cacheable.
done!
from cacheable.
I am wondering if we need to pull the code from v7 and create that as a branch as the current one is too new still and after testing there seems to be a ton of changes.
What if I created a branch that is just based on https://github.com/jaredwray/cacheable-request/releases/tag/v7.0.2 then you do a pull request against that with these changes?
from cacheable.
The other option is that we take the merge in on commonjs branch. Then we do a test to see if it breaks GOT if we release this updated code base as v7.0.3.
Thoughts?
from cacheable.
@Kikobeats - I went ahead and did a new branch called v7. I also added in the code changes that you outlined.
Could you validate this before I do the fix and release it as v7.0.3?
The reason I would like to test this is that there are significant code changes between this code and v7.0.2 and i want to make sure we are good with this release.
from cacheable.
Hello,
is this the code change? c09f1cd
The code looks good to me. It could better if a test unit is added.
from cacheable.
Thanks. Do you want to add a unit test to the v7 branch to validate? Also, how can we test that this version of cacheable-request
works well with got@11
? Is there a place to validate it well or a scenario where you are seeing the memory leak?
from cacheable.
@Kikobeats - have you been able to validate this code change?
from cacheable.
Sorry for the delay. The scenario is api.microlink.io, the endpoint is handling +50M requests per month, so it's very sensitive to little bugs like this.
Unfortunately, I don't have the time for writing the test – If you ship v7.0.3 I can test it on production servers and tell you 🙂
from cacheable.
https://www.npmjs.com/package/cacheable-request/v/7.0.3 with tag beta
from cacheable.
@jaredwray this version 7.0.3 broked new deploys in node version < 14. Please, check this issue: #246
from cacheable.
Thanks. the new release v7.0.4
should have resolved as it is based on 7.0.2.
from cacheable.
@Kikobeats - I rolled this back and did some changes on it for v7.0.5-beta.0
as it caused multiple issues. You can test this out by referencing the following github path.
https://github.com/jaredwray/cacheable-request/tree/v7
To do this in your npm package do the following:
// in your package.json
"dependencies": {
"cacheable-request": "jaredwray/cacheable-request#v7",
}
from cacheable.
closing on no response
from cacheable.
Related Issues (20)
- Upgrading xo package to ^0.49.0
- Migrating to Typescript
- Make proper changelogs HOT 1
- Hooks should be per-instance HOT 3
- Fail to run the test HOT 3
- Types needs to be updated for ESM HOT 2
- Cannot use namespace 'ResponseLike' as a type. HOT 18
- Could not find a declaration file for module 'http-cache-semantics' HOT 2
- [regression] Could not find a declaration file for module 'http-cache-semantics' HOT 3
- Memory leak HOT 4
- [question] security fix for http-cache-semantics 4.1.1 in v8 HOT 13
- Regular Expression Denial of Service (ReDoS) Vulnerability Found in a Package
- 7.0.3 Deployment now expects Node Version > 14, breaking change. HOT 9
- Nodejs version 20 creates error with Request
- [email protected] requires Node.js >= 16 HOT 4
- Sourcemaps point to missing source files HOT 2
- When upgrading to latest get-stream it is no longer compatible with nodejs 16
- LICENSE text (MIT) missing in npm module HOT 1
- Thoughts on using standardized web Request / Response / Headers? HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cacheable.