GithubHelp home page GithubHelp logo

Comments (5)

jaredwray avatar jaredwray commented on June 9, 2024 2

@elliot40404 - this was a pretty nasty bug and we added in more code to handle all the use cases. Here all all the cases we now handle on has and it will be released in v5 when alpha goes live in the next couple weeks.

  • When it is Map() the has does not handle expiring so we need to detect that type and handle it for that case.
  • If it is a Keyv Storage Adapter we need to assume they will handle the expiring correctly. Note, we found a bug in @keyv/sqlite and have plans to fix that also in the next 30 days where it doesnt handle the expires.
  • If it does not have a has function on the storage adapter then we handle it all ourselves and check the expires

Nice find!

from keyv.

jaredwray avatar jaredwray commented on June 9, 2024

@elliot40404 - thanks for sending this over and I will be working to test this and if if so get a fix out with v5 of keyv which should be in alpha this quarter.

from keyv.

elliot40404 avatar elliot40404 commented on June 9, 2024

Hey @jaredwray, thanks for looking into this. I can take this on if you like and create a PR.

from keyv.

jaredwray avatar jaredwray commented on June 9, 2024

That would be great. Do you want to work on main branch for this?

from keyv.

elliot40404 avatar elliot40404 commented on June 9, 2024

Yes I can work on main, but if you have any other branch on mind please do let me know.

from keyv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.