Comments (5)
@elliot40404 - this was a pretty nasty bug and we added in more code to handle all the use cases. Here all all the cases we now handle on has
and it will be released in v5 when alpha goes live in the next couple weeks.
- When it is
Map()
the has does not handle expiring so we need to detect that type and handle it for that case. - If it is a Keyv Storage Adapter we need to assume they will handle the expiring correctly. Note, we found a bug in
@keyv/sqlite
and have plans to fix that also in the next 30 days where it doesnt handle theexpires
. - If it does not have a
has
function on the storage adapter then we handle it all ourselves and check theexpires
Nice find!
from keyv.
@elliot40404 - thanks for sending this over and I will be working to test this and if if so get a fix out with v5 of keyv which should be in alpha this quarter.
from keyv.
Hey @jaredwray, thanks for looking into this. I can take this on if you like and create a PR.
from keyv.
That would be great. Do you want to work on main
branch for this?
from keyv.
Yes I can work on main, but if you have any other branch on mind please do let me know.
from keyv.
Related Issues (20)
- sqlite adapter iterator stack overflows HOT 4
- SSL/TLS Support for Redis Connections HOT 3
- Support for later versions of MongoDB Node.js Driver HOT 3
- Get rid of json-buffer HOT 3
- ⚠️ Critical dependency: the request of a dependency is an expression HOT 1
- Namespace will be missed using KeyvMongo HOT 2
- Support for setting multiples keys HOT 2
- Cannot find module '@keyv/sqlite' when using keyv in nextjs 14 app HOT 1
- When creating multiple instances of Keyv with postgres adapter, table creation fails and keyv not working HOT 1
- Data not being stored using KeyvRedis - Issue With Typescript HOT 3
- Download failed HOT 1
- `@keyv/redis`: `useRedisSets` option does not take effect when providing `ioredis` instance HOT 1
- RedisJSON with Keyv HOT 5
- Use Redis UNLINK instead of Redis DEL HOT 2
- Check the namespace provided to Redis doesn not include ":" HOT 7
- MaxListenersExceededWarning: Possible EventEmitter memory leak detected. HOT 1
- Strange compile error after upgrading @keyv/redis to 2.8.1 HOT 4
- How does the TTL work? HOT 1
- import or require webpack error. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from keyv.