MACRO min/max under WINDOWS about cxxopts

[supercairos]

I usually define NOMINMAX as preprocessor def in VS

[jarro2783]

Which version of the compiler? I've had a few other people discuss MSVC and they haven't had issues.

Does it also work if you add an extra set of parentheses around the argument to min and max?

[amigo421]

extra parentheses doesn't solve the problem,
VC toolchain is version 15, aka VisualStudio 2017

this is a known issue, see here or here

the description in MSDN here

[jarro2783]

I'm happy to accept a pull request. I wonder if a better option would be to write (std::max)(x, y) as suggested by the StackOverflow answers, rather than #undef.

[amigo421]

sure, Ill perform a few tests with both variants and raise a request

[jarro2783]

Is this still an issue for you?

[supercairos]

I'm using cxxopts on Windows and have no issue to report. The preprocessor flags on Windows does the trick. Le 23 août 2017 13:44, "jarro2783" <[email protected]> a écrit :

…

Is this still an issue for you? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#49 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAr_I0ODpPeWpPhDxHP8FD3tf0CjJW7nks5sbBCLgaJpZM4Nk0om> .

[Robmaister]

I just picked this up for a project on Windows. Definitely use the built-in NOMINMAX define for Windows.h instead of trying to undef it manually.

If you undef, #include <cxxopts.hpp> would have side-effects for applications assuming that min and max are existing macros in later code, since the preprocessor has no scope.

Proper usage:

#ifndef NOMINMAX
#define NOMINMAX
#endif

#include <Windows.h>

#include <cxxopts.hpp>

An example that would break with #undef:

#include <Windows.h>
#include <cxxopts.hpp>

int main (int argc, char* argv[]) {
    return max(2, 3);
}

[amigo421]

agreed ,NOMINMAX prefered way and it works fine for me too
request can be closed without modification the library

[zhongjingjogy]

@jarro2783 I am sorry to bother the rest of others about a closed issue. As someone who tries to use cxxopts on windows with MSVC, I found it is very frustrated to deal with MACRO min/max under WINDOWS. I should blame that MSVC introduce such an annoying feature that affects extensively. But I would sugguest that opensource library should provide more friendly solution to third party users. As an example, add parenthesis to anywhere you have min and max as it is suggested by NIRO

(std::numeric_limits<size_type>::max)()
(std::min)
(std::max)

As it is said,

No need for the NOMINMAX macro in this case, plus you won't get compiler warnings

I wrote this in memory of my lost 30 minutes at this time.

[jarro2783]

That seems like a reasonable workaround. I'll make the changes at some point soonish.