jas88 / nccid Goto Github PK

Currently 'submitting centre' is hard-coded to 'NHS Tayside'; should probably default to 'NHS Scotland' and/or be configurable at runtime

Add Coveralls to CI runs

Windows file enumeration still using \ instead of / for delimiter, so uploaded S3 objects get incorrect path.

Make search for DICOM files include subdirectories to allow the exported hierarchy from HIC

nccid version reports 1.0.0 rather than the current release.

Regex probably not catching legacy-style .\

Current code assumes PCR test result is numerical (0/1) - upstream now sending as text e.g. "Negative" - make parsing more flexible to accommodate this.

Need to implement proper unit testing and CI with Github Actions.

Strip duplicate slashes etc from path before upload

Uploading 100+GB batches is likely to need the ability to resume interrupted upload processes.

PatientGroup (training/validation split) no longer required for upload - split is done further up the pipeline now, per FL email of 2021-07-23.

Now need to specify a regional endpoint to avoid AmazonClientException: No RegionEndpoint or ServiceURL configured