Two bugs in 1.7.0 due to including graphql dependency. about graphql-request

[kentcdodds]

I'm happy with that so long as the bundle size stays below 15kb 👍 thanks!

[kentcdodds]

Interesting! I'll give it a look. Thanks!

[kentcdodds]

Super! Verified with my reproduction and it's back down to 12.6 KiB. Thank you!

[divyenduz]

Thanks for reporting this. Related issue: graphql/graphql-js#1272

@timsuchanek : We need just the print function from graphql-js, extracting that inline will remove the graphql dependency and reduce bundle size. Sounds good?

I will also add bundle size check in CI.

[divyenduz]

Added bundlesize to CI here: #96
It is still under 3 KB, of course it is not counting the peer dep size.

Is it possible for you to configure webpack to not include unused code from peer dep?

[kentcdodds]

Is it possible for you to configure webpack to not include unused code from peer dep?

What do you mean? This line is importing the peer dep, so that code is used (though the module may be tree-shaken, that's still a LOT of code). I'm pretty certain that the feature must be dropped entirely. If someone wants that feature then they can use one of the many other libraries that provide this capability... The appeal of graphql-request is its size. If this isn't changed, then I'll probably look for another module or fork this one if I ever need changes, which is fine, I just thought that the goal of this module was to fill the needs of size-conscious people like me.

[divyenduz]

It is definitely a goal to maintain the tiny size of this project. Which is why I want to work with you and reliably detect the impact of any dependencies change in CI.

Currently, the bundlesize check is CI passes. Also, the size reported by bundlephobia is under 15 KB as you had originally asked for.

[kentcdodds]

Hmm... I updated the example to use 1.8.0 and the bundle size is still the same and I'm still getting the console error.

Maybe there's a bug in bundlephobia. The fact is that graphql-request is using print from graphql which is what's causing the issues. If I remove the line import { print } from 'graphql' then the size goes down to 12.6 KiB.

I don't think it's possible to import print from graphql and keep the filesize down because print requires a LOT of code. And it's impossible to tree-shake that because it's used in the source code. I mean, you could restructure the code so folks who want that support can import another file or something, but I think that would be pointless because people who use that don't care about size and can therefore use another package altogether.

[divyenduz]

@kentcdodds: Thanks for working with me on this one and providing the reproduction. This PR reverts this feature: #97

Further actions for me:-

1. • Create issue for reliably detecting bundle size in CI to avoid this regression in future, both bundlephobia and bundlesize didn't work for graphql being a peer dependency.
2. • Reopen the issue #10

Thanks!

[divyenduz]

This is release in 1.8.1 🎉