Stop timer when page is not visible about timeme.js

[henryruhs]

Imagine someone likes to track the duration from using a clickout button to the moment the visitor is returning back to the website? This feature request is not invalid, control and behaviour is a task of the consuming project or library.

[jasonzissman]

I apologize for taking so long to get back to this. I agree with both of your assessments. I'll include this shortly.

[jasonzissman]

I have merged the suggested changes into master. Please let me know if I can help with anything else.

[henryruhs]

Why did you ignore my comment and merged the pull request without a discussion?

What if someone likes to track a duration from the pagehide to the pageshow event? This pull requests makes your library useless for people who have that usecase. In my opinion such kind of behaviour is not a task for your library, it's upon the project that is consuming your library to control when the duration starts, ends or whatever!?

This is breaking the "separation of concerns" principles.

[jasonzissman]

So I've had some time to reflect on the original issue some more. I think Redaxmedia is right - the calling application should make the decision on whether they really want to start the timer or not. At a minimum the calling application could perform the exact same conditional check (TimeMe.getIfVisibleHandle().now() == false) to make the decision if appropriate.

For now I will revert the changes. I will keep this issue open in the mean time in case we need to continue the discussion or if someone provides counterpoints. Sorry for the back-tracking!

[henryruhs]

Haha, somethings it needs a year to change a opinion. Great move!