Is NashornSandboxImpl.eval threadsafe about delight-nashorn-sandbox

[mxro]

Hi Bhanu, it has not been designed specifically to be thread-safe so I would recommend rather not doing it.

That being said, be welcome to have a look through the code and check if there are any non-thread safe operations!

[hyperpape]

It appears to me that produceSecureBindings has a thread safety issue.

                cached = scriptEngine.getBindings(ScriptContext.ENGINE_SCOPE);
                sanitizeBindings(cached);
                if (!allowExitFunctions) {
                    sb.append("var quit=function(){};var exit=function(){};");
                }
                if (!allowPrintFunctions) {
                    sb.append("var print=function(){};var echo = function(){};");
                }
                if (!allowReadFunctions) {
                    sb.append("var readFully=function(){};").append("var readLine=function(){};");
                }
                if (!allowLoadFunctions) {
                    sb.append("var load=function(){};var loadWithNewGlobal=function(){};");
                }
                if (!allowGlobalsObjects) {
                    // Max 22nd of Feb 2018: I don't think these are strictly necessary since they are only available in scripting mode
                    sb.append("var $ARG=null;var $ENV=null;var $EXEC=null;");
                    sb.append("var $OPTIONS=null;var $OUT=null;var $ERR=null;var $EXIT=null;");
                }
                scriptEngine.eval(sb.toString());

                resetEngineBindings();

cached is instantiated and then mutated, but there is no guarantee that multiple threads are not within in this same block at once (or even that one thread will see engineAsserted = true before it sees cached set).

[mxro]

@hyperpape Thank you for finding this. Could you raise a separate issue for this so we can track it there and fix it? Thank you!