GithubHelp home page GithubHelp logo

Comments (4)

spahnke avatar spahnke commented on July 29, 2024

We cannot use the library directly because we had to implement some assumptions for compatibility reasons with our previous engine, that we can't contribute to a general purpose engine. So we maintain our own fork and try to contribute everything we can back to this project. That said, I found a commit we have integrated in our fork that we never contributed, where we removed the finalizer because we hit the same problem. Either I just forgot to do that or I refrained from doing so because I couldn't reproduce the problem reliably.

This is the commit spahnke@08d3921

Are you able to build the library with the above patch applied yourself and can test if that mitigates the problem? If yes, I can submit a PR as soon as you have confirmed that it solves your problem.

from javascript.net.

Uncreal avatar Uncreal commented on July 29, 2024

Thank you!
I will try your solution.
I will report back tomorrow if the issue is resolved.

from javascript.net.

Uncreal avatar Uncreal commented on July 29, 2024

@spahnke i can confirm this error is gone with your changes.
Thank you!

from javascript.net.

spahnke avatar spahnke commented on July 29, 2024

Thanks for confirming! I created PR #92 for this.

from javascript.net.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.