GithubHelp home page GithubHelp logo

Comments (16)

jvlflame avatar jvlflame commented on July 22, 2024 1

Dmmja with english translation enabled will be how its working today?

Yep.

from javinizer.

jvlflame avatar jvlflame commented on July 22, 2024

What command are you running?

from javinizer.

jvlflame avatar jvlflame commented on July 22, 2024

Also, if you're running v1.7.3, installation documentation is currently located under a different branch.

from javinizer.

zuko7177 avatar zuko7177 commented on July 22, 2024

I upgraded to 2.0.0 alpha 4 and JavLibrary is working now.

However, Dmm is not translating to EN. Is the translation working? (I understand it's alpha...)
I updated jvSettings.json:
"sort.metadata.nfo.translate": 1,
"sort.metadata.nfo.translate.language": "en",
and run Javinizer without parameters.

from javinizer.

jvlflame avatar jvlflame commented on July 22, 2024

The translation is only intended for the description that is pulled from dmm. Otherwise if you wanted english language metadata you would probably pull from R18 or other scrapers. I'll make that more clear in the setting name and once I put together the settings documentation.

from javinizer.

zuko7177 avatar zuko7177 commented on July 22, 2024

Translation only for Dmm description makes sense. However, my description for Dmm is not getting translated.
Is there a setting I can check besides these?
"sort.metadata.nfo.translate": 1,
"sort.metadata.nfo.translate.language": "en",

from javinizer.

jvlflame avatar jvlflame commented on July 22, 2024

Ah, actually just realized there's currently a bug with it in 2.0.0-alpha4.
It's currently fixed on my dev branch but I haven't pushed the next alpha release yet.

I'll probably put out the next alpha build in a few hours.

from javinizer.

zuko7177 avatar zuko7177 commented on July 22, 2024

Thank you so much for your time.

An alternative approach without using a translation service would be to scrape the EN version of DMM.

You would have to do a second request for the EN version (note the /en in URL):
https://www.dmm.co.jp/en/mono/dvd/-/detail/=/cid=13gvg852/?i3_ref=search&i3_ord=1
Include the following cookies

  • ckcy: 2

  • cklg: en

  • age_check_done: 1 (to bypass age check)

Then go after the English description.
Perhaps a future feature to consider.

I recently submitted a PR for JAVMovieScraper to do this. Not sure if it will get approved :)
DoctorD1501/JAVMovieScraper#332

from javinizer.

jvlflame avatar jvlflame commented on July 22, 2024

Oh, that's a good idea. Whenever I previously tried to access the english version of the DMM site, I got an error page of Not available in your region.

Is it new that they've opened it up to different regions? Regardless, I'l definitely look into adding that.

from javinizer.

zuko7177 avatar zuko7177 commented on July 22, 2024

Hmm... perhaps it is region locked. I'm US based and it works for me.
I did not consider it might be locked for some regions.

from javinizer.

jvlflame avatar jvlflame commented on July 22, 2024

I'm also US based. Last time I tried to access the english page was probably ~1+ yrs ago so who knows.

from javinizer.

zuko7177 avatar zuko7177 commented on July 22, 2024

I can confirm translation for Dmm plot is working as expected in alpha5.
Thanks.

from javinizer.

jvlflame avatar jvlflame commented on July 22, 2024

Converting this ticket to work on english dmm scraper source.

from javinizer.

zuko7177 avatar zuko7177 commented on July 22, 2024

I've noticed that the Google translation are slightly better. Perhaps make it an option to use either Google or DMM english?

from javinizer.

jvlflame avatar jvlflame commented on July 22, 2024

I'm splitting them into two scrapers so you'll be able to select which one you use.
-dmm
-dmmja

It'll be a good alternative since the googletrans api has rate limits so if you're scraping thousands of movies at a time it'll start throwing errors.

from javinizer.

zuko7177 avatar zuko7177 commented on July 22, 2024

Ah so dmm will be english version of website.
Dmmja with english translation enabled will be how its working today?

from javinizer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.