Comments (3)
I've written a simple fix for the above described issue, by pushing down the workflow object id into the query.
Please see commit: JohnieBraaf@58f4962
I see that I have left some debugging code, so please ignore that.
Let me know what you think @javrasya
from django-river.
Hi @JohnieBraaf. Thanks for reporting this and for the PR. I think this is a bug that should definitely be fixed probably in a similar way you did in your PR.
The thing is that the get_available_approvals
method is an abstract method that both MSSQL and other DB versions are implementing. So we can't just update it for the MSSQL one.
The other thing is that this method is for fetching all available approvals for a user on every object but also can be used for a single workflow object. In such case I also think the object id should be passed down instead of applying the ORM
filter on top of that (in here).
I will try to drop some comments on your changes. Let's try to discuss it there. Maybe even initialize a PR to have the conversation there.
from django-river.
Thnx @javrasya for your feedback, I will have a look
from django-river.
Related Issues (20)
- Delete object from model HOT 4
- [Question] How to incorporate multi-tenancy with django river?
- display river status details in DetailView
- can I create related_name for <river.models.State> HOT 1
- Workflow pattern issue (circular not working) HOT 10
- Will you consider adding pre-commit to help enforce syntax and formatting standards? HOT 2
- When does the hook trigger in django-river?
- How can i use django river with django reset framework HOT 1
- type object 'TransitionApproval' has no attribute '_mptt_meta' HOT 1
- Multiple button shown if User belongs to more than one Group with workflow permissions HOT 1
- Return ticket current state status
- Error while running django async
- Permissions allow users to approver specific records only
- example of usage
- Material/Tutorial
- how to deal with the namespace
- Any active fork? HOT 2
- mptt version Conflicts ?
- What about Django 4.* support? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-river.