some spaces in docx is removed about leanify

[javiergutierrezchamorro]

@TPS it is already updated in the repository as r440: https://sourceforge.net/p/nikkhokkho/code/440/

[JayXon]

The switch to pugixml is complete. Could you guys try out the latest nightly? Thanks.

[TPS]

Thanks, @JayXon & @javiergutierrezchamorro.

[javiergutierrezchamorro]

Have not found yet any document that experiences the removal of spaces. Not sure if this is a highly probable issue or not.

[contra-tiempo]

This situation often occures in the graph or sheet captions.

[contra-tiempo]

Is this bug fixed now? The offcial says RapidXml has a better performance.

[JayXon]

There is a workaround to skip a xml inside docx, so it should be safe to use leanify on docx now.
But I'm not sure if this issue happens to xlsx and pptx.
Rapidxml looks like a dead project, haven't updated for 5 years.

[TPS]

Known issue filed @ leethomason/tinyxml2#242. Maybe chime in there? Author seems unwilling needs help/patch to fix.

[JayXon]

I'm considering switching to pugixml, although it does not support xml:space="preserve", it has parse_ws_pcdata_single flag which will preserve white space in this case. It's also much faster than Tinyxml2 yet still lightweight.

[javiergutierrezchamorro]

Being it faster is a good deal for nowadays large XML files.

[TPS]

I figured bringing it up directly @ zeux/pugixml#74 would probably be helpful.… ☺

Update: Heh, @zeux seems to have accepted zeux/pugixml#74 as enhancement.… Stay tuned! ☺

Last update from zeux/pugixml#74: Oh, well, denied (for perhaps good reasons — read the long update in linked issue).

How do you all plan to proceed?

[JayXon]

I can always stick to the original plan of using parse_ws_pcdata_single even if pugixml doesn't support xml:space="preserve". It will keep unnecessary whitespace in some cases, but it's better than corrupt the file.

@zeux also mentioned that I should be able to remove the unnecessary whitespace in Leanify by using "some advanced client code".

[TPS]

I figured that's how you'd want to go.… Looking forward to it! ☺

[TPS]

I use it via FileOptimizer, so, how about it, @javiergutierrezchamorro?

[JayXon]

Closing this, feel free to reopen this or create a new issue if you found any problem.

[TPS]

Sorry to necropost, but has PugiXML (or current XML parser/optimizer) done everything needed for this? Just FYI, TinyXML just got this implemented @ leethomason/tinyxml2#941.