GithubHelp home page GithubHelp logo

Comments (5)

jonbullock avatar jonbullock commented on August 20, 2024

Hi Peter,

Absolutely fine with me.

from jbake-example-project-thymeleaf.

msgilligan avatar msgilligan commented on August 20, 2024

There are also three templates (index.thymeleaf, archive.thymeleaf, tags.thymeleaf) where the th:with is not used, resulting in bad links like: nullarchive.html. I was going to submit a PR that added three more instances of:

th:with="rootpath=(${content.rootpath != null} ? ${content.rootpath} : '')"

in order to correct that.

@pitpalme Do you have a pull request to simplify that (by defaulting to '' elsewhere) or should I go ahead and submit an (easier for a JBake beginner) PR that just modified the three template files to contain the redundant code?

Update: In tags.html, rootpath needs to be defaulted to '../' to work correctly -- and there's an even worse problem with the includes. Looks like this really does need to be solved in the (Java?) code that initializes content.rootpath

from jbake-example-project-thymeleaf.

jonbullock avatar jonbullock commented on August 20, 2024

Hi Sean the default value for rootpath should be ../ when rendering the tag files, that's set here: https://github.com/jbake-org/jbake/blob/master/src/main/java/org/jbake/app/Renderer.java#L233

Is this not the case?

from jbake-example-project-thymeleaf.

msgilligan avatar msgilligan commented on August 20, 2024

I think my problem was caused by using version 2.4.0 of the bake command-line tool to initialize the project assets/templates/content, but configuring JBake 2.3.2 in my Gradle file. I created another project later using 2.4.0 consistently and did not have the problem.

from jbake-example-project-thymeleaf.

ottlinger avatar ottlinger commented on August 20, 2024

@pitpalme any progress on the PR? I'd greatly appreciate a more up2date version of thymeleaf templates in the upcoming new release of jBake. Thanks

from jbake-example-project-thymeleaf.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.