GithubHelp home page GithubHelp logo

Comments (9)

jbboehr avatar jbboehr commented on June 12, 2024 1

Okay, I've opened #85 with psr/[email protected]

I also implemented 2.0 [0], but literally none of the libraries we test against are using it yet and it totally breaks them, so probably should hold off on that.

from php-psr.

stof avatar stof commented on June 12, 2024 1

@jbboehr the change done in a minor version was perfectly valid, thanks to variance rules.

The issue is that enabling this extension ignores entirely the package requirements (as the interface at the version selected by composer won't be loaded at all).
This extension basically defeats any attempt of versioning the PSR packages.

from php-psr.

sergeyklay avatar sergeyklay commented on June 12, 2024

Is this works for you:

{
    "require": {
        "ext-psr": "*"
    },
    "provide": {
        "psr/container": "^1"
    },
}

from php-psr.

derrabus avatar derrabus commented on June 12, 2024

@sergeyklay No, that would just uninstall the psr/container package.

from php-psr.

sergeyklay avatar sergeyklay commented on June 12, 2024

Well, as far as I know, this is usually what you should do anyway. Otherwise, you end up with two sources providing the same interface.

from php-psr.

jbboehr avatar jbboehr commented on June 12, 2024

Kinda surprised they would change the interface in a non-major version. Looks like there's a 2.0 version out. I suppose we should update. Can you foresee any compatibility issues with phalcon @sergeyklay ?

from php-psr.

jbboehr avatar jbboehr commented on June 12, 2024

Based on my reading of the mailing list at the time, it was my understanding that breaking interface changes would be published as a new library (e.g. psr/container2). It looks like they are not doing this.

from php-psr.

Jeckerson avatar Jeckerson commented on June 12, 2024

@jbboehr Could you create separate branch with updated interfraces so I could test it?

In case if this interfaces changes will break something from our side we will wait for new release from you. As we are almost ready to release Phalcon with PHP8 support: phalcon/cphalcon#15287

from php-psr.

jbboehr avatar jbboehr commented on June 12, 2024

The issue is that enabling this extension ignores entirely the package requirements (as the interface at the version selected by composer won't be loaded at all).
This extension basically defeats any attempt of versioning the PSR packages.

This is just how extensions work and there is no resolution unless composer provides support for managing extensions. And well, I foolishly wasn't expecting there to ever be another version of a PSR without it being published as a new PSR in another namespace.

from php-psr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.