Failed assertion for Fidelity accounts about beancount-import

[jbms]

Would you care to create a fix and ideally also run ofx_sanitize (you may have to modify ofx_sanitize though or manually edit the result to retain important numerical values) to create a new test case that covers this?

Is the unit price in your OFX file "incorrect" because it includes the fee as part of the price? I think that is actually the correct thing to do from an accounting perspective, but I see that is not what ofx.py currently expects.

[scanta2]

I do have a small fix that I am using on my machine. There's no fee, I just think the unit price is rounded too much in the ofx file itself.

…

On Mon, Jan 27, 2020 at 12:51 PM Jeremy Maitin-Shepard < ***@***.***> wrote: Would you care to create a fix and ideally also run ofx_sanitize (you may have to modify ofx_sanitize though or manually edit the result to retain important numerical values) to create a new test case that covers this? Is the unit price in your OFX file "incorrect" because it includes the fee as part of the price? I think that is actually the correct thing to do from an accounting perspective, but I see that is not what ofx.py currently expects. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#47?email_source=notifications&email_token=ADCNKWMA7BVV3IVN77EW6ILQ74UKXA5CNFSM4KLRPGUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKAT74Y#issuecomment-578895859>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADCNKWMD3Y3CZ6OPAWM2PCLQ74UKXANCNFSM4KLRPGUA> .

[tdickman]

@scanta2 I'm running into the same issue with another provider - your fork fixed it for me perfectly. Any change you can create a PR against this version?

[scanta2]

I did create a PR but somehow it didn't pass the tests and nobody merged it.

…

On Thu, Jul 23, 2020, 18:30 Tom Dickman ***@***.***> wrote: @scanta2 <https://github.com/scanta2> I'm running into the same issue with another provider - your fork <https://github.com/scanta2/beancount-import/tree/FailedAssertOFX> fixed it for me perfectly. Any change you can create a PR against this version? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADCNKWIW6E4EFJJV73GW6KLR5DBZZANCNFSM4KLRPGUA> .

[jbms]

Thanks again @scanta2 for your pull request. I apologize for the long delay in responding to As might be apparent, I haven't had a lot of time to devote to this tool lately. I just added a few comments to your pull request regarding the test failures.

If either you or @tdickman is able to provide a sanitized OFX file to serve as a test case for this issue, that would be extremely helpful. Dealing with this type of data is unfortunately inherently pretty finicky, so having test cases is pretty critical to avoid regressions in the future.