GithubHelp home page GithubHelp logo

Comments (4)

jbt avatar jbt commented on June 18, 2024

Just been looking into this. I'm guessing it's to do with the fact that Prism.highlight(text, grammar) doesn't run the various extra hooks that the line-numbers class uses. I'll have a look to see if I can add those in to make them work

from mdedit.

greenlaw110 avatar greenlaw110 commented on June 18, 2024

I think this is more complicated than I thought. What I need is not a line number for the entire page, but the capability to mark lines in code blocks

E.g. if I have the following md file:

image

I expect to have line numbers in the rendered code block:

image

from mdedit.

greenlaw110 avatar greenlaw110 commented on June 18, 2024

I think this should be an issue with markdown-it, not mdEdit

from mdedit.

greenlaw110 avatar greenlaw110 commented on June 18, 2024

Okay it's nether markdown-it issue nor mdEditor issue, the following code change in the glue js take me to where I want:

Old code:

    var md = markdownit({
      html: true,
      highlight: function (code, lang) {
        if (languageOverrides[lang]) lang = languageOverrides[lang];
        if (lang && Prism.languages[lang]) {
          return Prism.highlight(code, Prism.languages[lang]);
        }
        return code;
      }
    }).use(markdownitFootnote);

New code:

    var md = markdownit({
      html: true,
      highlight: function (code, lang) {
        if (languageOverrides[lang]) lang = languageOverrides[lang];
        if (lang && Prism.languages[lang]) {
          var codeElement = document.createElement("code");
          codeElement.innerHTML = code;
          codeElement.className = 'language-' + lang + ' line-numbers';
          var preElement = document.createElement("pre");
          preElement.appendChild(codeElement);
          Prism.highlightElement(codeElement);
          return codeElement.innerHTML;
        }
        return code;
      }
    }).use(markdownitFootnote);

And now I get the line numbers in the rendering result:

image

from mdedit.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.