Comments (4)
Just been looking into this. I'm guessing it's to do with the fact that Prism.highlight(text, grammar)
doesn't run the various extra hooks that the line-numbers class uses. I'll have a look to see if I can add those in to make them work
from mdedit.
I think this is more complicated than I thought. What I need is not a line number for the entire page, but the capability to mark lines in code blocks
E.g. if I have the following md file:
I expect to have line numbers in the rendered code block:
from mdedit.
I think this should be an issue with markdown-it, not mdEdit
from mdedit.
Okay it's nether markdown-it issue nor mdEditor issue, the following code change in the glue js take me to where I want:
Old code:
var md = markdownit({
html: true,
highlight: function (code, lang) {
if (languageOverrides[lang]) lang = languageOverrides[lang];
if (lang && Prism.languages[lang]) {
return Prism.highlight(code, Prism.languages[lang]);
}
return code;
}
}).use(markdownitFootnote);
New code:
var md = markdownit({
html: true,
highlight: function (code, lang) {
if (languageOverrides[lang]) lang = languageOverrides[lang];
if (lang && Prism.languages[lang]) {
var codeElement = document.createElement("code");
codeElement.innerHTML = code;
codeElement.className = 'language-' + lang + ' line-numbers';
var preElement = document.createElement("pre");
preElement.appendChild(codeElement);
Prism.highlightElement(codeElement);
return codeElement.innerHTML;
}
return code;
}
}).use(markdownitFootnote);
And now I get the line numbers in the rendering result:
from mdedit.
Related Issues (19)
- Use Bower? HOT 2
- Add documentation on supported markdown elements HOT 1
- Performance issues in Firefox HOT 5
- Which browsers does this library support? HOT 7
- Add support for right-to-left languages HOT 2
- Use selected subset of Prism? HOT 1
- When paste something with an empty line, an additional line is added each time. HOT 1
- Gulp HOT 3
- How can I use API to move cursor? HOT 2
- It doesn't allow me to type in Chinese character HOT 2
- Is this project still live? HOT 2
- Make Editor.paste support API call to insert string in place
- Improve continuelist-esque behaviour
- Indented code block not get syntax hightlighted
- Nearly not responding when editing on a very big file
- Figure out wtf this syntax was supposed to be HOT 1
- Ignore more keyCodes when triggering changes
- Need a whole pile of functions and events for measuring / scrolling HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mdedit.