Comments (8)
@yegor256 could you please consider resolution of the issue?
from jcabi-log.
@longtimeago but we don't work with log4j anyhow in this library. We only communicate with slf4j. Or I missed something?
from jcabi-log.
@yegor256 Yes, log4j is optional but we use it for MulticolorLayout
.
PatternLayout
from log4j2 supports coloring.
So we could upgrade to log4j2, get rid of MulticolorLayout
and have all other nice features from log4j2
from jcabi-log.
@longtimeago yeah, right, but we don't need any other features from log4j :) MulticolorLayout is the only place where we use log4j. Maybe it's time to just delete it, since log4j2 supports colors out of the box?
from jcabi-log.
@yegor256 Yes, this is good option :)
In this case clients which still want coloring would have to use migrate on log4j2.
Beware, it's not a straightforward process. One thing I know is that log4j2 does not support configuration in property files, xml only
from jcabi-log.
@yegor256 can we proceed here?
from jcabi-log.
@longtimeago I gave it another thought... what is the point of removing it? we have users, the class is rather convenient. what exactly is the goal?
from jcabi-log.
@yegor256 I thought again ... looks like you are right. There is no reason in removing MulticolorLayout
as well as well as removing optional dependency on log4j.
from jcabi-log.
Related Issues (20)
- Logger.format() can't process args with positions HOT 30
- SupplierLoggerTest.java:43-45: Some tests here are... HOT 1
- DomDecor: why is object allowed to be passed to ctor? HOT 1
- Logger fails to build complex strings with positional substitutes HOT 8
- [nano] decor example is not working HOT 3
- let's get rid of aspects HOT 8
- All jcabi libraries are not working with JDK13 because logger uses invalid refrelction access HOT 3
- let's use latest version of SLF4j API HOT 6
- slf4j 2.0 HOT 12
- fresh release HOT 3
- refresh HOT 3
- LoggerMocker would be nice to have HOT 1
- Dependency Dashboard
- depends on mockito-core as compile scope, is a mistake? HOT 7
- too much text in RetryOnFailure with verbose=OFF
- Install Fails on Maven-Invoker_Plugin HOT 3
- Upgrading parent in pom.xml from 1.20.1 to 1.23 causes checkstyle errors HOT 3
- Upgrading parent in pom.xml from 1.20.1 to 1.23 and fixing checkstyle errors causes PMD errors. HOT 6
- Add example log output HOT 3
- VerboseProcessTest.java:52-55: Locale/encoding problem in two test... HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jcabi-log.