GithubHelp home page GithubHelp logo

Consider upgrade to log4j2 about jcabi-log HOT 8 CLOSED

jcabi avatar jcabi commented on June 16, 2024
Consider upgrade to log4j2

from jcabi-log.

Comments (8)

longtimeago avatar longtimeago commented on June 16, 2024

@yegor256 could you please consider resolution of the issue?

from jcabi-log.

yegor256 avatar yegor256 commented on June 16, 2024

@longtimeago but we don't work with log4j anyhow in this library. We only communicate with slf4j. Or I missed something?

from jcabi-log.

longtimeago avatar longtimeago commented on June 16, 2024

@yegor256 Yes, log4j is optional but we use it for MulticolorLayout.
PatternLayout from log4j2 supports coloring.
So we could upgrade to log4j2, get rid of MulticolorLayout and have all other nice features from log4j2

from jcabi-log.

yegor256 avatar yegor256 commented on June 16, 2024

@longtimeago yeah, right, but we don't need any other features from log4j :) MulticolorLayout is the only place where we use log4j. Maybe it's time to just delete it, since log4j2 supports colors out of the box?

from jcabi-log.

longtimeago avatar longtimeago commented on June 16, 2024

@yegor256 Yes, this is good option :)
In this case clients which still want coloring would have to use migrate on log4j2.
Beware, it's not a straightforward process. One thing I know is that log4j2 does not support configuration in property files, xml only

from jcabi-log.

longtimeago avatar longtimeago commented on June 16, 2024

@yegor256 can we proceed here?

from jcabi-log.

yegor256 avatar yegor256 commented on June 16, 2024

@longtimeago I gave it another thought... what is the point of removing it? we have users, the class is rather convenient. what exactly is the goal?

from jcabi-log.

longtimeago avatar longtimeago commented on June 16, 2024

@yegor256 I thought again ... looks like you are right. There is no reason in removing MulticolorLayout as well as well as removing optional dependency on log4j.

from jcabi-log.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.