GithubHelp home page GithubHelp logo

Comments (13)

yegor256 avatar yegor256 commented on September 25, 2024

totally agree, thanks for reporting

from jcabi-log.

yegor256 avatar yegor256 commented on September 25, 2024

@dmarkov please pay for it

from jcabi-log.

dmarkov avatar dmarkov commented on September 25, 2024

@yegor256 sure! @krzyk thanks for reporting, 15 mins was added to your account (trn ID: 36462119)

from jcabi-log.

dmarkov avatar dmarkov commented on September 25, 2024

@carlosmiranda the task is for you now, follow these guidelines. Don't hesitate to ask any technical questions right here

from jcabi-log.

dmarkov avatar dmarkov commented on September 25, 2024

@carlosmiranda The budget here is 30 mins, which is exactly how much time will be paid for, when the task is completed

from jcabi-log.

carlosmiranda avatar carlosmiranda commented on September 25, 2024

Should it really throw IllegalArgumentException in this case? No exception is thrown because internally, Logger uses String.format(), which [ignores extra arguments if there are more arguments than format specifiers](http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#format%28java.lang.String, java.lang.Object...%29).

from jcabi-log.

yegor256 avatar yegor256 commented on September 25, 2024

I think we should throw a runtime exception, as @krzyk suggested. String.format() is less strict about it, but this is not our style :)

from jcabi-log.

carlosmiranda avatar carlosmiranda commented on September 25, 2024

All right, pull request is #9 for review. :)

from jcabi-log.

carlosmiranda avatar carlosmiranda commented on September 25, 2024

@krzyk , this should be fixed now. Please close the issue or let me know if there's anything more that's needed.

from jcabi-log.

yegor256 avatar yegor256 commented on September 25, 2024

I'll release a new version to Maven Central once the ticket is closed

from jcabi-log.

krzyk avatar krzyk commented on September 25, 2024

Looks good to me.

from jcabi-log.

yegor256 avatar yegor256 commented on September 25, 2024

version 0.12.2 was released to Maven Central

from jcabi-log.

dmarkov avatar dmarkov commented on September 25, 2024

@carlosmiranda Many thanks! 30 mins were added to your account in Transaction ID 36819376

from jcabi-log.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.